openzeppelin_relayer/models/transaction/

repository.rs

use super::evm::Speed;
use crate::{
    config::ServerConfig,
    constants::{
        DEFAULT_GAS_LIMIT, DEFAULT_TRANSACTION_SPEED, FINAL_TRANSACTION_STATUSES,
        STELLAR_DEFAULT_MAX_FEE, STELLAR_DEFAULT_TRANSACTION_FEE,
        STELLAR_SPONSORED_TRANSACTION_VALIDITY_MINUTES,
    },
    domain::{
        evm::PriceParams,
        stellar::validation::{validate_operations, validate_soroban_memo_restriction},
        transaction::stellar::utils::extract_time_bounds,
        xdr_utils::{is_signed, parse_transaction_xdr},
        SignTransactionResponseEvm,
    },
    models::{
        transaction::{
            request::{evm::EvmTransactionRequest, stellar::StellarTransactionRequest},
            solana::SolanaInstructionSpec,
            stellar::{DecoratedSignature, MemoSpec, OperationSpec},
        },
        AddressError, EvmNetwork, NetworkRepoModel, NetworkTransactionRequest, NetworkType,
        RelayerError, RelayerRepoModel, SignerError, StellarNetwork, StellarValidationError,
        TransactionError, U256,
    },
    utils::{
        deserialize_i64, deserialize_optional_i64, deserialize_optional_u128, serialize_i64,
        serialize_optional_i64, serialize_optional_u128,
    },
};
use alloy::{
    consensus::{TxEip1559, TxLegacy},
    primitives::{Address as AlloyAddress, Bytes, TxKind},
    rpc::types::AccessList,
};

use chrono::{Duration, Utc};
use serde::{Deserialize, Serialize};
use soroban_rs::xdr::{TransactionEnvelope, TransactionV1Envelope, VecM};
use std::{convert::TryFrom, str::FromStr};
use strum::Display;

use utoipa::ToSchema;
use uuid::Uuid;

use soroban_rs::xdr::Transaction as SorobanTransaction;

#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, ToSchema, Display)]
#[serde(rename_all = "lowercase")]
pub enum TransactionStatus {
    Canceled,
    Pending,
    Sent,
    Submitted,
    Mined,
    Confirmed,
    Failed,
    Expired,
}

#[derive(Debug, Clone, Serialize, Deserialize, Default, PartialEq)]
/// Metadata for a transaction
pub struct TransactionMetadata {
    /// Number of consecutive failures
    #[serde(default)]
    pub consecutive_failures: u32,
    #[serde(default)]
    pub total_failures: u32,
    /// Number of submission retries triggered by Stellar insufficient-fee errors
    #[serde(default)]
    pub insufficient_fee_retries: u32,
    /// Number of submission retries triggered by Stellar TRY_AGAIN_LATER responses
    #[serde(default)]
    pub try_again_later_retries: u32,
    /// Number of submission retries triggered by EVM "nonce too high" errors
    #[serde(default)]
    pub nonce_too_high_retries: u32,
}

impl TransactionMetadata {
    /// Returns a copy with `nonce_too_high_retries` reset to 0, or `None` if already 0.
    pub fn with_nonce_retries_reset(&self) -> Option<Self> {
        if self.nonce_too_high_retries == 0 {
            return None;
        }
        Some(Self {
            nonce_too_high_retries: 0,
            ..self.clone()
        })
    }
}

#[derive(Debug, Clone, Serialize, Deserialize, Default)]
pub struct TransactionUpdateRequest {
    #[serde(skip_serializing_if = "Option::is_none")]
    pub status: Option<TransactionStatus>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub status_reason: Option<String>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub sent_at: Option<String>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub confirmed_at: Option<String>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub network_data: Option<NetworkTransactionData>,
    /// Timestamp when gas price was determined
    #[serde(skip_serializing_if = "Option::is_none")]
    pub priced_at: Option<String>,
    /// History of transaction hashes
    #[serde(skip_serializing_if = "Option::is_none")]
    pub hashes: Option<Vec<String>>,
    /// Number of no-ops in the transaction
    #[serde(skip_serializing_if = "Option::is_none")]
    pub noop_count: Option<u32>,
    /// Whether the transaction is canceled
    #[serde(skip_serializing_if = "Option::is_none")]
    pub is_canceled: Option<bool>,
    /// Timestamp when this transaction should be deleted (for final states)
    #[serde(skip_serializing_if = "Option::is_none")]
    pub delete_at: Option<String>,
    /// Status check metadata (failure counters for circuit breaker)
    #[serde(skip_serializing_if = "Option::is_none")]
    pub metadata: Option<TransactionMetadata>,
}

#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct TransactionRepoModel {
    pub id: String,
    pub relayer_id: String,
    pub status: TransactionStatus,
    pub status_reason: Option<String>,
    pub created_at: String,
    pub sent_at: Option<String>,
    pub confirmed_at: Option<String>,
    pub valid_until: Option<String>,
    /// Timestamp when this transaction should be deleted (for final states)
    pub delete_at: Option<String>,
    pub network_data: NetworkTransactionData,
    /// Timestamp when gas price was determined
    pub priced_at: Option<String>,
    /// History of transaction hashes
    pub hashes: Vec<String>,
    pub network_type: NetworkType,
    pub noop_count: Option<u32>,
    pub is_canceled: Option<bool>,
    /// Status check metadata (failure counters for circuit breaker)
    #[serde(default)]
    pub metadata: Option<TransactionMetadata>,
}

impl TransactionRepoModel {
    /// Validates the transaction repository model
    ///
    /// # Returns
    /// * `Ok(())` if the transaction is valid
    /// * `Err(TransactionError)` if validation fails
    pub fn validate(&self) -> Result<(), TransactionError> {
        Ok(())
    }

    /// Calculate when this transaction should be deleted based on its status and expiration hours
    /// Supports fractional hours (e.g., 0.1 = 6 minutes).
    fn calculate_delete_at(expiration_hours: f64) -> Option<String> {
        // Convert fractional hours to seconds (e.g., 0.1 hours = 360 seconds)
        let seconds = (expiration_hours * 3600.0) as i64;
        let delete_time = Utc::now() + Duration::seconds(seconds);
        Some(delete_time.to_rfc3339())
    }

    /// Update delete_at field if status changed to a final state
    pub fn update_delete_at_if_final_status(&mut self) {
        if self.delete_at.is_none() && FINAL_TRANSACTION_STATUSES.contains(&self.status) {
            let expiration_hours = ServerConfig::get_transaction_expiration_hours();
            self.delete_at = Self::calculate_delete_at(expiration_hours);
        }
    }

    /// Apply partial updates to this transaction model
    ///
    /// This method encapsulates the business logic for updating transaction fields,
    /// ensuring consistency across all repository implementations.
    ///
    /// # Arguments
    /// * `update` - The partial update request containing the fields to update
    pub fn apply_partial_update(&mut self, update: TransactionUpdateRequest) {
        // Apply partial updates
        if let Some(status) = update.status {
            self.status = status;
            self.update_delete_at_if_final_status();
        }
        if let Some(status_reason) = update.status_reason {
            self.status_reason = Some(status_reason);
        }
        if let Some(sent_at) = update.sent_at {
            self.sent_at = Some(sent_at);
        }
        if let Some(confirmed_at) = update.confirmed_at {
            self.confirmed_at = Some(confirmed_at);
        }
        if let Some(network_data) = update.network_data {
            self.network_data = network_data;
        }
        if let Some(priced_at) = update.priced_at {
            self.priced_at = Some(priced_at);
        }
        if let Some(hashes) = update.hashes {
            self.hashes = hashes;
        }
        if let Some(noop_count) = update.noop_count {
            self.noop_count = Some(noop_count);
        }
        if let Some(is_canceled) = update.is_canceled {
            self.is_canceled = Some(is_canceled);
        }
        if let Some(delete_at) = update.delete_at {
            self.delete_at = Some(delete_at);
        }
        if let Some(metadata) = update.metadata {
            self.metadata = Some(metadata);
        }
    }

    /// Creates a TransactionUpdateRequest to reset this transaction to its pre-prepare state.
    /// This is used when a transaction needs to be retried from the beginning (e.g., bad sequence error).
    ///
    /// For Stellar transactions:
    /// - Resets status to Pending
    /// - Clears sent_at and confirmed_at timestamps
    /// - Resets hashes array
    /// - Calls reset_to_pre_prepare_state on the StellarTransactionData
    ///
    /// For other networks, only resets the common fields.
    pub fn create_reset_update_request(
        &self,
    ) -> Result<TransactionUpdateRequest, TransactionError> {
        let network_data = match &self.network_data {
            NetworkTransactionData::Stellar(stellar_data) => Some(NetworkTransactionData::Stellar(
                stellar_data.clone().reset_to_pre_prepare_state(),
            )),
            // For other networks, we don't modify the network data
            _ => None,
        };

        Ok(TransactionUpdateRequest {
            status: Some(TransactionStatus::Pending),
            status_reason: None,
            sent_at: None,
            confirmed_at: None,
            network_data,
            priced_at: None,
            hashes: Some(vec![]),
            noop_count: None,
            is_canceled: None,
            delete_at: None,
            metadata: None,
        })
    }
}

#[derive(Debug, Clone, Serialize, Deserialize)]
#[serde(tag = "network_data", content = "data")]
#[allow(clippy::large_enum_variant)]
pub enum NetworkTransactionData {
    Evm(EvmTransactionData),
    Solana(SolanaTransactionData),
    Stellar(StellarTransactionData),
}

impl NetworkTransactionData {
    pub fn get_evm_transaction_data(&self) -> Result<EvmTransactionData, TransactionError> {
        match self {
            NetworkTransactionData::Evm(data) => Ok(data.clone()),
            _ => Err(TransactionError::InvalidType(
                "Expected EVM transaction".to_string(),
            )),
        }
    }

    pub fn get_solana_transaction_data(&self) -> Result<SolanaTransactionData, TransactionError> {
        match self {
            NetworkTransactionData::Solana(data) => Ok(data.clone()),
            _ => Err(TransactionError::InvalidType(
                "Expected Solana transaction".to_string(),
            )),
        }
    }

    pub fn get_stellar_transaction_data(&self) -> Result<StellarTransactionData, TransactionError> {
        match self {
            NetworkTransactionData::Stellar(data) => Ok(data.clone()),
            _ => Err(TransactionError::InvalidType(
                "Expected Stellar transaction".to_string(),
            )),
        }
    }
}

#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, ToSchema)]
pub struct EvmTransactionDataSignature {
    pub r: String,
    pub s: String,
    pub v: u8,
    pub sig: String,
}

#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct EvmTransactionData {
    #[serde(
        serialize_with = "serialize_optional_u128",
        deserialize_with = "deserialize_optional_u128",
        default
    )]
    pub gas_price: Option<u128>,
    pub gas_limit: Option<u64>,
    pub nonce: Option<u64>,
    pub value: U256,
    pub data: Option<String>,
    pub from: String,
    pub to: Option<String>,
    pub chain_id: u64,
    pub hash: Option<String>,
    pub signature: Option<EvmTransactionDataSignature>,
    pub speed: Option<Speed>,
    #[serde(
        serialize_with = "serialize_optional_u128",
        deserialize_with = "deserialize_optional_u128",
        default
    )]
    pub max_fee_per_gas: Option<u128>,
    #[serde(
        serialize_with = "serialize_optional_u128",
        deserialize_with = "deserialize_optional_u128",
        default
    )]
    pub max_priority_fee_per_gas: Option<u128>,
    pub raw: Option<Vec<u8>>,
}

impl EvmTransactionData {
    /// Creates transaction data for replacement by combining existing transaction data with new request data.
    ///
    /// Preserves critical fields like chain_id, from address, and nonce while applying new transaction parameters.
    /// Pricing fields are cleared and must be calculated separately.
    ///
    /// # Arguments
    /// * `old_data` - The existing transaction data to preserve core fields from
    /// * `request` - The new transaction request containing updated parameters
    ///
    /// # Returns
    /// New `EvmTransactionData` configured for replacement transaction
    pub fn for_replacement(old_data: &EvmTransactionData, request: &EvmTransactionRequest) -> Self {
        Self {
            // Preserve existing fields from old transaction
            chain_id: old_data.chain_id,
            from: old_data.from.clone(),
            nonce: old_data.nonce, // Preserve original nonce for replacement

            // Apply new fields from request
            to: request.to.clone(),
            value: request.value,
            data: request.data.clone(),
            gas_limit: request.gas_limit,
            speed: request
                .speed
                .clone()
                .or_else(|| old_data.speed.clone())
                .or(Some(DEFAULT_TRANSACTION_SPEED)),

            // Clear pricing fields - these will be calculated later
            gas_price: None,
            max_fee_per_gas: None,
            max_priority_fee_per_gas: None,

            // Reset signing fields
            signature: None,
            hash: None,
            raw: None,
        }
    }

    /// Updates the transaction data with calculated price parameters.
    ///
    /// # Arguments
    /// * `price_params` - Calculated pricing parameters containing gas price and EIP-1559 fees
    ///
    /// # Returns
    /// The updated `EvmTransactionData` with pricing information applied
    pub fn with_price_params(mut self, price_params: PriceParams) -> Self {
        self.gas_price = price_params.gas_price;
        self.max_fee_per_gas = price_params.max_fee_per_gas;
        self.max_priority_fee_per_gas = price_params.max_priority_fee_per_gas;

        self
    }

    /// Updates the transaction data with an estimated gas limit.
    ///
    /// # Arguments
    /// * `gas_limit` - The estimated gas limit for the transaction
    ///
    /// # Returns
    /// The updated `EvmTransactionData` with the new gas limit
    pub fn with_gas_estimate(mut self, gas_limit: u64) -> Self {
        self.gas_limit = Some(gas_limit);
        self
    }

    /// Updates the transaction data with a specific nonce value.
    ///
    /// # Arguments
    /// * `nonce` - The nonce value to set for the transaction
    ///
    /// # Returns
    /// The updated `EvmTransactionData` with the specified nonce
    pub fn with_nonce(mut self, nonce: u64) -> Self {
        self.nonce = Some(nonce);
        self
    }

    /// Updates the transaction data with signature information from a signed transaction response.
    ///
    /// # Arguments
    /// * `sig` - The signed transaction response containing signature, hash, and raw transaction data
    ///
    /// # Returns
    /// The updated `EvmTransactionData` with signature information applied
    pub fn with_signed_transaction_data(mut self, sig: SignTransactionResponseEvm) -> Self {
        self.signature = Some(sig.signature);
        self.hash = Some(sig.hash);
        self.raw = Some(sig.raw);
        self
    }
}

#[cfg(test)]
impl Default for EvmTransactionData {
    fn default() -> Self {
        Self {
            from: "0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266".to_string(), // Standard Hardhat test address
            to: Some("0x70997970C51812dc3A010C7d01b50e0d17dc79C8".to_string()), // Standard Hardhat test address
            gas_price: Some(20000000000),
            value: U256::from(1000000000000000000u128), // 1 ETH
            data: Some("0x".to_string()),
            nonce: Some(1),
            chain_id: 1,
            gas_limit: Some(DEFAULT_GAS_LIMIT),
            hash: None,
            signature: None,
            speed: None,
            max_fee_per_gas: None,
            max_priority_fee_per_gas: None,
            raw: None,
        }
    }
}

#[cfg(test)]
impl Default for TransactionRepoModel {
    fn default() -> Self {
        Self {
            id: "00000000-0000-0000-0000-000000000001".to_string(),
            relayer_id: "00000000-0000-0000-0000-000000000002".to_string(),
            status: TransactionStatus::Pending,
            created_at: "2023-01-01T00:00:00Z".to_string(),
            status_reason: None,
            sent_at: None,
            confirmed_at: None,
            valid_until: None,
            delete_at: None,
            network_data: NetworkTransactionData::Evm(EvmTransactionData::default()),
            network_type: NetworkType::Evm,
            priced_at: None,
            hashes: Vec::new(),
            noop_count: None,
            is_canceled: Some(false),
            metadata: None,
        }
    }
}

pub trait EvmTransactionDataTrait {
    fn is_legacy(&self) -> bool;
    fn is_eip1559(&self) -> bool;
    fn is_speed(&self) -> bool;
}

impl EvmTransactionDataTrait for EvmTransactionData {
    fn is_legacy(&self) -> bool {
        self.gas_price.is_some()
    }

    fn is_eip1559(&self) -> bool {
        self.max_fee_per_gas.is_some() && self.max_priority_fee_per_gas.is_some()
    }

    fn is_speed(&self) -> bool {
        self.speed.is_some()
    }
}

#[derive(Debug, Clone, Serialize, Deserialize, Default)]
pub struct SolanaTransactionData {
    /// Pre-built serialized transaction (base64) - mutually exclusive with instructions
    pub transaction: Option<String>,
    /// Instructions to build transaction from - mutually exclusive with transaction
    pub instructions: Option<Vec<SolanaInstructionSpec>>,
    /// Transaction signature after submission
    pub signature: Option<String>,
}

impl SolanaTransactionData {
    /// Creates a new `SolanaTransactionData` with an updated signature.
    /// Moves the data to avoid unnecessary cloning.
    pub fn with_signature(mut self, signature: String) -> Self {
        self.signature = Some(signature);
        self
    }
}

/// Represents different input types for Stellar transactions
#[derive(Debug, Clone, Serialize, Deserialize)]
pub enum TransactionInput {
    /// Operations to be built into a transaction
    Operations(Vec<OperationSpec>),
    /// Pre-built unsigned XDR that needs signing
    UnsignedXdr(String),
    /// Pre-built signed XDR that needs fee-bumping
    SignedXdr {
        xdr: String,
        // String-encoded like `sequence_number` to stay precise through storage
        // serialization; see `serialize_i64`.
        #[serde(serialize_with = "serialize_i64", deserialize_with = "deserialize_i64")]
        max_fee: i64,
    },
    /// Soroban gas abstraction: FeeForwarder transaction with user's signed auth entry
    /// The XDR is the FeeForwarder transaction from /build, and the signed_auth_entry
    /// contains the user's signed SorobanAuthorizationEntry to be injected.
    SorobanGasAbstraction {
        xdr: String,
        signed_auth_entry: String,
    },
}

impl Default for TransactionInput {
    fn default() -> Self {
        TransactionInput::Operations(vec![])
    }
}

impl TransactionInput {
    /// Create a TransactionInput from a StellarTransactionRequest
    pub fn from_stellar_request(
        request: &StellarTransactionRequest,
    ) -> Result<Self, TransactionError> {
        // Handle Soroban gas abstraction mode (XDR + signed_auth_entry)
        if let (Some(xdr), Some(signed_auth_entry)) =
            (&request.transaction_xdr, &request.signed_auth_entry)
        {
            // Validation: signed_auth_entry and fee_bump are mutually exclusive
            // (already validated in StellarTransactionRequest::validate(), but double-check here)
            if request.fee_bump == Some(true) {
                return Err(TransactionError::ValidationError(
                    "Cannot use both signed_auth_entry and fee_bump".to_string(),
                ));
            }

            return Ok(TransactionInput::SorobanGasAbstraction {
                xdr: xdr.clone(),
                signed_auth_entry: signed_auth_entry.clone(),
            });
        }

        // Handle XDR mode
        if let Some(xdr) = &request.transaction_xdr {
            let envelope = parse_transaction_xdr(xdr, false)
                .map_err(|e| TransactionError::ValidationError(e.to_string()))?;

            return if request.fee_bump == Some(true) {
                // Fee bump requires signed XDR
                if !is_signed(&envelope) {
                    Err(TransactionError::ValidationError(
                        "Cannot request fee_bump with unsigned XDR".to_string(),
                    ))
                } else {
                    let max_fee = request.max_fee.unwrap_or(STELLAR_DEFAULT_MAX_FEE);
                    Ok(TransactionInput::SignedXdr {
                        xdr: xdr.clone(),
                        max_fee,
                    })
                }
            } else {
                // No fee bump - must be unsigned
                if is_signed(&envelope) {
                    Err(TransactionError::ValidationError(
                        StellarValidationError::UnexpectedSignedXdr.to_string(),
                    ))
                } else {
                    Ok(TransactionInput::UnsignedXdr(xdr.clone()))
                }
            };
        }

        // Handle operations mode
        if let Some(operations) = &request.operations {
            if operations.is_empty() {
                return Err(TransactionError::ValidationError(
                    "Operations must not be empty".to_string(),
                ));
            }

            if request.fee_bump == Some(true) {
                return Err(TransactionError::ValidationError(
                    "Cannot request fee_bump with operations mode".to_string(),
                ));
            }

            // Validate operations
            validate_operations(operations)
                .map_err(|e| TransactionError::ValidationError(e.to_string()))?;

            // Validate Soroban memo restriction
            validate_soroban_memo_restriction(operations, &request.memo)
                .map_err(|e| TransactionError::ValidationError(e.to_string()))?;

            return Ok(TransactionInput::Operations(operations.clone()));
        }

        // Neither XDR nor operations provided
        Err(TransactionError::ValidationError(
            "Must provide either operations or transaction_xdr".to_string(),
        ))
    }
}

#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct StellarTransactionData {
    pub source_account: String,
    pub fee: Option<u32>,
    // String-encoded to keep large i64s precise through storage serialization;
    // see `serialize_optional_i64`.
    #[serde(
        serialize_with = "serialize_optional_i64",
        deserialize_with = "deserialize_optional_i64",
        default
    )]
    pub sequence_number: Option<i64>,
    pub memo: Option<MemoSpec>,
    pub valid_until: Option<String>,
    pub network_passphrase: String,
    pub signatures: Vec<DecoratedSignature>,
    pub hash: Option<String>,
    pub simulation_transaction_data: Option<String>,
    pub transaction_input: TransactionInput,
    pub signed_envelope_xdr: Option<String>,
    pub transaction_result_xdr: Option<String>,
}

impl StellarTransactionData {
    /// Resets the transaction data to its pre-prepare state by clearing all fields
    /// that are populated during the prepare and submit phases.
    ///
    /// Fields preserved (from initial creation):
    /// - source_account, network_passphrase, memo, valid_until, transaction_input
    ///
    /// Fields reset to None/empty:
    /// - fee, sequence_number, signatures, signed_envelope_xdr, hash, simulation_transaction_data
    pub fn reset_to_pre_prepare_state(mut self) -> Self {
        // Reset all fields populated during prepare phase
        self.fee = None;
        self.sequence_number = None;
        self.signatures = vec![];
        self.signed_envelope_xdr = None;
        self.simulation_transaction_data = None;

        // Reset fields populated during submit phase
        self.hash = None;

        self
    }

    /// Updates the Stellar transaction data with a specific sequence number.
    ///
    /// # Arguments
    /// * `sequence_number` - The sequence number for the Stellar account
    ///
    /// # Returns
    /// The updated `StellarTransactionData` with the specified sequence number
    pub fn with_sequence_number(mut self, sequence_number: i64) -> Self {
        self.sequence_number = Some(sequence_number);
        self
    }

    /// Updates the Stellar transaction data with the actual fee charged by the network.
    ///
    /// # Arguments
    /// * `fee` - The actual fee charged in stroops
    ///
    /// # Returns
    /// The updated `StellarTransactionData` with the specified fee
    pub fn with_fee(mut self, fee: u32) -> Self {
        self.fee = Some(fee);
        self
    }

    /// Updates the Stellar transaction data with the transaction result XDR.
    ///
    /// # Arguments
    /// * `transaction_result_xdr` - The XDR-encoded transaction result return value
    ///
    /// # Returns
    /// The updated `StellarTransactionData` with the specified transaction result
    pub fn with_transaction_result_xdr(mut self, transaction_result_xdr: String) -> Self {
        self.transaction_result_xdr = Some(transaction_result_xdr);
        self
    }

    /// Builds an unsigned envelope from any transaction input.
    ///
    /// Returns an envelope without signatures, suitable for simulation and fee calculation.
    ///
    /// # Returns
    /// * `Ok(TransactionEnvelope)` containing the unsigned transaction
    /// * `Err(SignerError)` if the transaction data cannot be converted
    pub fn build_unsigned_envelope(&self) -> Result<TransactionEnvelope, SignerError> {
        match &self.transaction_input {
            TransactionInput::Operations(_) => {
                // Build from operations without signatures
                self.build_envelope_from_operations_unsigned()
            }
            TransactionInput::UnsignedXdr(xdr) => {
                // Parse the XDR as-is (already unsigned)
                self.parse_xdr_envelope(xdr)
            }
            TransactionInput::SignedXdr { xdr, .. } => {
                // Parse the inner transaction (for fee-bump cases)
                self.parse_xdr_envelope(xdr)
            }
            TransactionInput::SorobanGasAbstraction { xdr, .. } => {
                // Parse the FeeForwarder transaction XDR
                self.parse_xdr_envelope(xdr)
            }
        }
    }

    /// Gets the transaction envelope for simulation purposes.
    ///
    /// Convenience method that delegates to build_unsigned_envelope().
    ///
    /// # Returns
    /// * `Ok(TransactionEnvelope)` containing the unsigned transaction
    /// * `Err(SignerError)` if the transaction data cannot be converted
    pub fn get_envelope_for_simulation(&self) -> Result<TransactionEnvelope, SignerError> {
        self.build_unsigned_envelope()
    }

    /// Builds a signed envelope ready for submission to the network.
    ///
    /// Uses cached signed_envelope_xdr if available, otherwise builds from components.
    ///
    /// # Returns
    /// * `Ok(TransactionEnvelope)` containing the signed transaction
    /// * `Err(SignerError)` if the transaction data cannot be converted
    pub fn build_signed_envelope(&self) -> Result<TransactionEnvelope, SignerError> {
        // If we have a cached signed envelope, use it
        if let Some(ref xdr) = self.signed_envelope_xdr {
            return self.parse_xdr_envelope(xdr);
        }

        // Otherwise, build from components
        match &self.transaction_input {
            TransactionInput::Operations(_) => {
                // Build from operations with signatures
                self.build_envelope_from_operations_signed()
            }
            TransactionInput::UnsignedXdr(xdr) => {
                // Parse and attach signatures
                let envelope = self.parse_xdr_envelope(xdr)?;
                self.attach_signatures_to_envelope(envelope)
            }
            TransactionInput::SignedXdr { xdr, .. } => {
                // Already signed
                self.parse_xdr_envelope(xdr)
            }
            TransactionInput::SorobanGasAbstraction { xdr, .. } => {
                // For Soroban gas abstraction, the signed auth entry is injected during prepare
                // Parse and attach the relayer's signature
                let envelope = self.parse_xdr_envelope(xdr)?;
                self.attach_signatures_to_envelope(envelope)
            }
        }
    }

    /// Gets the transaction envelope for submission to the network.
    ///
    /// Convenience method that delegates to build_signed_envelope().
    ///
    /// # Returns
    /// * `Ok(TransactionEnvelope)` containing the signed transaction
    /// * `Err(SignerError)` if the transaction data cannot be converted
    pub fn get_envelope_for_submission(&self) -> Result<TransactionEnvelope, SignerError> {
        self.build_signed_envelope()
    }

    // Helper method to build unsigned envelope from operations
    fn build_envelope_from_operations_unsigned(&self) -> Result<TransactionEnvelope, SignerError> {
        let tx = SorobanTransaction::try_from(self.clone())?;
        Ok(TransactionEnvelope::Tx(TransactionV1Envelope {
            tx,
            signatures: VecM::default(),
        }))
    }

    // Helper method to build signed envelope from operations
    fn build_envelope_from_operations_signed(&self) -> Result<TransactionEnvelope, SignerError> {
        let tx = SorobanTransaction::try_from(self.clone())?;
        let signatures = VecM::try_from(self.signatures.clone())
            .map_err(|_| SignerError::ConversionError("too many signatures".into()))?;
        Ok(TransactionEnvelope::Tx(TransactionV1Envelope {
            tx,
            signatures,
        }))
    }

    // Helper method to parse XDR envelope
    fn parse_xdr_envelope(&self, xdr: &str) -> Result<TransactionEnvelope, SignerError> {
        use soroban_rs::xdr::{Limits, ReadXdr};
        TransactionEnvelope::from_xdr_base64(xdr, Limits::none())
            .map_err(|e| SignerError::ConversionError(format!("Invalid XDR: {e}")))
    }

    // Helper method to attach signatures to an envelope
    fn attach_signatures_to_envelope(
        &self,
        envelope: TransactionEnvelope,
    ) -> Result<TransactionEnvelope, SignerError> {
        use soroban_rs::xdr::{Limits, ReadXdr, WriteXdr};

        // Serialize and re-parse to get a mutable version
        let envelope_xdr = envelope.to_xdr_base64(Limits::none()).map_err(|e| {
            SignerError::ConversionError(format!("Failed to serialize envelope: {e}"))
        })?;

        let mut envelope = TransactionEnvelope::from_xdr_base64(&envelope_xdr, Limits::none())
            .map_err(|e| SignerError::ConversionError(format!("Failed to parse envelope: {e}")))?;

        let sigs = VecM::try_from(self.signatures.clone())
            .map_err(|_| SignerError::ConversionError("too many signatures".into()))?;

        match &mut envelope {
            TransactionEnvelope::Tx(ref mut v1) => v1.signatures = sigs,
            TransactionEnvelope::TxV0(ref mut v0) => v0.signatures = sigs,
            TransactionEnvelope::TxFeeBump(_) => {
                return Err(SignerError::ConversionError(
                    "Cannot attach signatures to fee-bump transaction directly".into(),
                ));
            }
        }

        Ok(envelope)
    }

    /// Updates instance with the given signature appended to the signatures list.
    ///
    /// # Arguments
    /// * `sig` - The decorated signature to append
    ///
    /// # Returns
    /// The updated `StellarTransactionData` with the new signature added
    pub fn attach_signature(mut self, sig: DecoratedSignature) -> Self {
        self.signatures.push(sig);
        self
    }

    /// Updates instance with the transaction hash populated.
    ///
    /// # Arguments
    /// * `hash` - The transaction hash to set
    ///
    /// # Returns
    /// The updated `StellarTransactionData` with the hash field set
    pub fn with_hash(mut self, hash: String) -> Self {
        self.hash = Some(hash);
        self
    }

    /// Return a new instance with simulation data applied (fees and transaction extension).
    pub fn with_simulation_data(
        mut self,
        sim_response: soroban_rs::stellar_rpc_client::SimulateTransactionResponse,
        operations_count: u64,
    ) -> Result<Self, SignerError> {
        use tracing::info;

        // Update fee based on simulation (using soroban-helpers formula)
        let inclusion_fee = operations_count * STELLAR_DEFAULT_TRANSACTION_FEE as u64;
        let resource_fee = sim_response.min_resource_fee;

        let updated_fee = u32::try_from(inclusion_fee + resource_fee)
            .map_err(|_| SignerError::ConversionError("Fee too high".to_string()))?
            .max(STELLAR_DEFAULT_TRANSACTION_FEE);
        self.fee = Some(updated_fee);

        // Store simulation transaction data for TransactionExt::V1
        self.simulation_transaction_data = Some(sim_response.transaction_data);

        info!(
            "Applied simulation fee: {} stroops and stored transaction extension data",
            updated_fee
        );
        Ok(self)
    }
}

/// Extract valid_until: request > XDR time_bounds > default (for operations) > None (for XDR)
fn extract_stellar_valid_until(
    stellar_request: &StellarTransactionRequest,
    now: chrono::DateTime<Utc>,
) -> Option<String> {
    if let Some(vu) = &stellar_request.valid_until {
        return Some(vu.clone());
    }

    if let Some(xdr) = &stellar_request.transaction_xdr {
        if let Ok(envelope) = parse_transaction_xdr(xdr, false) {
            if let Some(tb) = extract_time_bounds(&envelope) {
                if tb.max_time.0 == 0 {
                    return None; // unbounded
                }
                if let Ok(timestamp) = i64::try_from(tb.max_time.0) {
                    if let Some(dt) = chrono::DateTime::from_timestamp(timestamp, 0) {
                        return Some(dt.to_rfc3339());
                    }
                }
            }
        }
        return None;
    }

    let default = now + Duration::minutes(STELLAR_SPONSORED_TRANSACTION_VALIDITY_MINUTES);
    Some(default.to_rfc3339())
}

impl
    TryFrom<(
        &NetworkTransactionRequest,
        &RelayerRepoModel,
        &NetworkRepoModel,
    )> for TransactionRepoModel
{
    type Error = RelayerError;

    fn try_from(
        (request, relayer_model, network_model): (
            &NetworkTransactionRequest,
            &RelayerRepoModel,
            &NetworkRepoModel,
        ),
    ) -> Result<Self, Self::Error> {
        let now = Utc::now().to_rfc3339();

        match request {
            NetworkTransactionRequest::Evm(evm_request) => {
                let network = EvmNetwork::try_from(network_model.clone())?;
                Ok(Self {
                    id: Uuid::new_v4().to_string(),
                    relayer_id: relayer_model.id.clone(),
                    status: TransactionStatus::Pending,
                    status_reason: None,
                    created_at: now,
                    sent_at: None,
                    confirmed_at: None,
                    valid_until: evm_request.valid_until.clone(),
                    delete_at: None,
                    network_type: NetworkType::Evm,
                    network_data: NetworkTransactionData::Evm(EvmTransactionData {
                        gas_price: evm_request.gas_price,
                        gas_limit: evm_request.gas_limit,
                        nonce: None,
                        value: evm_request.value,
                        data: evm_request.data.clone(),
                        from: relayer_model.address.clone(),
                        to: evm_request.to.clone(),
                        chain_id: network.id(),
                        hash: None,
                        signature: None,
                        speed: evm_request.speed.clone(),
                        max_fee_per_gas: evm_request.max_fee_per_gas,
                        max_priority_fee_per_gas: evm_request.max_priority_fee_per_gas,
                        raw: None,
                    }),
                    priced_at: None,
                    hashes: Vec::new(),
                    noop_count: None,
                    is_canceled: Some(false),
                    metadata: None,
                })
            }
            NetworkTransactionRequest::Solana(solana_request) => Ok(Self {
                id: Uuid::new_v4().to_string(),
                relayer_id: relayer_model.id.clone(),
                status: TransactionStatus::Pending,
                status_reason: None,
                created_at: now,
                sent_at: None,
                confirmed_at: None,
                valid_until: solana_request.valid_until.clone(),
                delete_at: None,
                network_type: NetworkType::Solana,
                network_data: NetworkTransactionData::Solana(SolanaTransactionData {
                    transaction: solana_request.transaction.clone().map(|t| t.into_inner()),
                    instructions: solana_request.instructions.clone(),
                    signature: None,
                }),
                priced_at: None,
                hashes: Vec::new(),
                noop_count: None,
                is_canceled: Some(false),
                metadata: None,
            }),
            NetworkTransactionRequest::Stellar(stellar_request) => {
                // Store the source account before consuming the request
                let source_account = stellar_request.source_account.clone();

                let valid_until = extract_stellar_valid_until(stellar_request, Utc::now());

                let transaction_input = TransactionInput::from_stellar_request(stellar_request)
                    .map_err(|e| RelayerError::ValidationError(e.to_string()))?;

                let stellar_data = StellarTransactionData {
                    source_account: source_account.unwrap_or_else(|| relayer_model.address.clone()),
                    memo: stellar_request.memo.clone(),
                    valid_until: valid_until.clone(),
                    network_passphrase: StellarNetwork::try_from(network_model.clone())?.passphrase,
                    signatures: Vec::new(),
                    hash: None,
                    fee: None,
                    sequence_number: None,
                    simulation_transaction_data: None,
                    transaction_input,
                    signed_envelope_xdr: None,
                    transaction_result_xdr: None,
                };

                Ok(Self {
                    id: Uuid::new_v4().to_string(),
                    relayer_id: relayer_model.id.clone(),
                    status: TransactionStatus::Pending,
                    status_reason: None,
                    created_at: now,
                    sent_at: None,
                    confirmed_at: None,
                    valid_until,
                    delete_at: None,
                    network_type: NetworkType::Stellar,
                    network_data: NetworkTransactionData::Stellar(stellar_data),
                    priced_at: None,
                    hashes: Vec::new(),
                    noop_count: None,
                    is_canceled: Some(false),
                    metadata: None,
                })
            }
        }
    }
}

impl EvmTransactionData {
    /// Converts the transaction's 'to' field to an Alloy Address.
    ///
    /// # Returns
    /// * `Ok(Some(AlloyAddress))` if the 'to' field contains a valid address
    /// * `Ok(None)` if the 'to' field is None or empty (contract creation)
    /// * `Err(SignerError)` if the address format is invalid
    pub fn to_address(&self) -> Result<Option<AlloyAddress>, SignerError> {
        Ok(match self.to.as_deref().filter(|s| !s.is_empty()) {
            Some(addr_str) => Some(AlloyAddress::from_str(addr_str).map_err(|e| {
                AddressError::ConversionError(format!("Invalid 'to' address: {e}"))
            })?),
            None => None,
        })
    }

    /// Converts the transaction's data field from hex string to bytes.
    ///
    /// # Returns
    /// * `Ok(Bytes)` containing the decoded transaction data
    /// * `Err(SignerError)` if the hex string is invalid
    pub fn data_to_bytes(&self) -> Result<Bytes, SignerError> {
        Bytes::from_str(self.data.as_deref().unwrap_or(""))
            .map_err(|e| SignerError::SigningError(format!("Invalid transaction data: {e}")))
    }
}

impl TryFrom<NetworkTransactionData> for TxLegacy {
    type Error = SignerError;

    fn try_from(tx: NetworkTransactionData) -> Result<Self, Self::Error> {
        match tx {
            NetworkTransactionData::Evm(tx) => {
                let tx_kind = match tx.to_address()? {
                    Some(addr) => TxKind::Call(addr),
                    None => TxKind::Create,
                };

                Ok(Self {
                    chain_id: Some(tx.chain_id),
                    nonce: tx.nonce.unwrap_or(0),
                    gas_limit: tx.gas_limit.unwrap_or(DEFAULT_GAS_LIMIT),
                    gas_price: tx.gas_price.unwrap_or(0),
                    to: tx_kind,
                    value: tx.value,
                    input: tx.data_to_bytes()?,
                })
            }
            _ => Err(SignerError::SigningError(
                "Not an EVM transaction".to_string(),
            )),
        }
    }
}

impl TryFrom<NetworkTransactionData> for TxEip1559 {
    type Error = SignerError;

    fn try_from(tx: NetworkTransactionData) -> Result<Self, Self::Error> {
        match tx {
            NetworkTransactionData::Evm(tx) => {
                let tx_kind = match tx.to_address()? {
                    Some(addr) => TxKind::Call(addr),
                    None => TxKind::Create,
                };

                Ok(Self {
                    chain_id: tx.chain_id,
                    nonce: tx.nonce.unwrap_or(0),
                    gas_limit: tx.gas_limit.unwrap_or(DEFAULT_GAS_LIMIT),
                    max_fee_per_gas: tx.max_fee_per_gas.unwrap_or(0),
                    max_priority_fee_per_gas: tx.max_priority_fee_per_gas.unwrap_or(0),
                    to: tx_kind,
                    value: tx.value,
                    access_list: AccessList::default(),
                    input: tx.data_to_bytes()?,
                })
            }
            _ => Err(SignerError::SigningError(
                "Not an EVM transaction".to_string(),
            )),
        }
    }
}

impl TryFrom<&EvmTransactionData> for TxLegacy {
    type Error = SignerError;

    fn try_from(tx: &EvmTransactionData) -> Result<Self, Self::Error> {
        let tx_kind = match tx.to_address()? {
            Some(addr) => TxKind::Call(addr),
            None => TxKind::Create,
        };

        Ok(Self {
            chain_id: Some(tx.chain_id),
            nonce: tx.nonce.unwrap_or(0),
            gas_limit: tx.gas_limit.unwrap_or(DEFAULT_GAS_LIMIT),
            gas_price: tx.gas_price.unwrap_or(0),
            to: tx_kind,
            value: tx.value,
            input: tx.data_to_bytes()?,
        })
    }
}

impl TryFrom<EvmTransactionData> for TxLegacy {
    type Error = SignerError;

    fn try_from(tx: EvmTransactionData) -> Result<Self, Self::Error> {
        Self::try_from(&tx)
    }
}

impl TryFrom<&EvmTransactionData> for TxEip1559 {
    type Error = SignerError;

    fn try_from(tx: &EvmTransactionData) -> Result<Self, Self::Error> {
        let tx_kind = match tx.to_address()? {
            Some(addr) => TxKind::Call(addr),
            None => TxKind::Create,
        };

        Ok(Self {
            chain_id: tx.chain_id,
            nonce: tx.nonce.unwrap_or(0),
            gas_limit: tx.gas_limit.unwrap_or(DEFAULT_GAS_LIMIT),
            max_fee_per_gas: tx.max_fee_per_gas.unwrap_or(0),
            max_priority_fee_per_gas: tx.max_priority_fee_per_gas.unwrap_or(0),
            to: tx_kind,
            value: tx.value,
            access_list: AccessList::default(),
            input: tx.data_to_bytes()?,
        })
    }
}

impl TryFrom<EvmTransactionData> for TxEip1559 {
    type Error = SignerError;

    fn try_from(tx: EvmTransactionData) -> Result<Self, Self::Error> {
        Self::try_from(&tx)
    }
}

impl From<&[u8; 65]> for EvmTransactionDataSignature {
    fn from(bytes: &[u8; 65]) -> Self {
        Self {
            r: hex::encode(&bytes[0..32]),
            s: hex::encode(&bytes[32..64]),
            v: bytes[64],
            sig: hex::encode(bytes),
        }
    }
}

#[cfg(test)]
mod tests {
    use lazy_static::lazy_static;
    use soroban_rs::xdr::{BytesM, Signature, SignatureHint};
    use std::sync::Mutex;

    use super::*;
    use crate::{
        config::{
            EvmNetworkConfig, NetworkConfigCommon, SolanaNetworkConfig, StellarNetworkConfig,
        },
        models::{
            network::NetworkConfigData,
            relayer::{
                RelayerEvmPolicy, RelayerNetworkPolicy, RelayerSolanaPolicy, RelayerStellarPolicy,
            },
            transaction::stellar::AssetSpec,
            EncodedSerializedTransaction, StellarFeePaymentStrategy,
        },
    };

    // Use a mutex to ensure tests don't run in parallel when modifying env vars
    lazy_static! {
        static ref ENV_MUTEX: Mutex<()> = Mutex::new(());
    }

    #[test]
    fn test_signature_from_bytes() {
        let test_bytes: [u8; 65] = [
            1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24,
            25, 26, 27, 28, 29, 30, 31, 32, // r (32 bytes)
            33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54,
            55, 56, 57, 58, 59, 60, 61, 62, 63, 64, // s (32 bytes)
            27, // v (1 byte)
        ];

        let signature = EvmTransactionDataSignature::from(&test_bytes);

        assert_eq!(signature.r.len(), 64); // 32 bytes in hex
        assert_eq!(signature.s.len(), 64); // 32 bytes in hex
        assert_eq!(signature.v, 27);
        assert_eq!(signature.sig.len(), 130); // 65 bytes in hex
    }

    #[test]
    fn test_transaction_metadata_nonce_too_high_retries_default() {
        let metadata = TransactionMetadata::default();
        assert_eq!(metadata.nonce_too_high_retries, 0);
        assert_eq!(metadata.consecutive_failures, 0);
        assert_eq!(metadata.total_failures, 0);
        assert_eq!(metadata.insufficient_fee_retries, 0);
        assert_eq!(metadata.try_again_later_retries, 0);
    }

    #[test]
    fn test_transaction_metadata_backward_compatibility() {
        // Simulate an old JSON payload without the nonce_too_high_retries field
        let old_json = r#"{
            "consecutive_failures": 1,
            "total_failures": 2,
            "insufficient_fee_retries": 3,
            "try_again_later_retries": 4
        }"#;

        let metadata: TransactionMetadata = serde_json::from_str(old_json).unwrap();
        assert_eq!(metadata.consecutive_failures, 1);
        assert_eq!(metadata.total_failures, 2);
        assert_eq!(metadata.insufficient_fee_retries, 3);
        assert_eq!(metadata.try_again_later_retries, 4);
        // Missing field should default to 0
        assert_eq!(metadata.nonce_too_high_retries, 0);
    }

    #[test]
    fn test_with_nonce_retries_reset_returns_none_when_zero() {
        let metadata = TransactionMetadata {
            consecutive_failures: 2,
            total_failures: 5,
            insufficient_fee_retries: 1,
            try_again_later_retries: 3,
            nonce_too_high_retries: 0,
        };
        assert!(metadata.with_nonce_retries_reset().is_none());
    }

    #[test]
    fn test_with_nonce_retries_reset_returns_reset_metadata() {
        let metadata = TransactionMetadata {
            consecutive_failures: 2,
            total_failures: 5,
            insufficient_fee_retries: 1,
            try_again_later_retries: 3,
            nonce_too_high_retries: 3,
        };
        let result = metadata.with_nonce_retries_reset();
        assert!(result.is_some());
        let reset = result.unwrap();
        assert_eq!(reset.nonce_too_high_retries, 0);
        assert_eq!(reset.consecutive_failures, 2);
        assert_eq!(reset.total_failures, 5);
        assert_eq!(reset.insufficient_fee_retries, 1);
        assert_eq!(reset.try_again_later_retries, 3);
    }

    #[test]
    fn test_stellar_transaction_data_reset_to_pre_prepare_state() {
        let stellar_data = StellarTransactionData {
            source_account: "GTEST".to_string(),
            fee: Some(100),
            sequence_number: Some(42),
            memo: Some(MemoSpec::Text {
                value: "test memo".to_string(),
            }),
            valid_until: Some("2024-12-31".to_string()),
            network_passphrase: "Test Network".to_string(),
            signatures: vec![], // Simplified - empty for test
            hash: Some("test-hash".to_string()),
            simulation_transaction_data: Some("simulation-data".to_string()),
            transaction_input: TransactionInput::Operations(vec![OperationSpec::Payment {
                destination: "GDEST".to_string(),
                amount: 1000,
                asset: AssetSpec::Native,
            }]),
            signed_envelope_xdr: Some("signed-xdr".to_string()),
            transaction_result_xdr: None,
        };

        let reset_data = stellar_data.clone().reset_to_pre_prepare_state();

        // Fields that should be preserved
        assert_eq!(reset_data.source_account, stellar_data.source_account);
        assert_eq!(reset_data.memo, stellar_data.memo);
        assert_eq!(reset_data.valid_until, stellar_data.valid_until);
        assert_eq!(
            reset_data.network_passphrase,
            stellar_data.network_passphrase
        );
        assert!(matches!(
            reset_data.transaction_input,
            TransactionInput::Operations(_)
        ));

        // Fields that should be reset
        assert_eq!(reset_data.fee, None);
        assert_eq!(reset_data.sequence_number, None);
        assert!(reset_data.signatures.is_empty());
        assert_eq!(reset_data.hash, None);
        assert_eq!(reset_data.simulation_transaction_data, None);
        assert_eq!(reset_data.signed_envelope_xdr, None);
    }

    #[test]
    fn test_transaction_repo_model_create_reset_update_request() {
        let stellar_data = StellarTransactionData {
            source_account: "GTEST".to_string(),
            fee: Some(100),
            sequence_number: Some(42),
            memo: None,
            valid_until: None,
            network_passphrase: "Test Network".to_string(),
            signatures: vec![],
            hash: Some("test-hash".to_string()),
            simulation_transaction_data: None,
            transaction_input: TransactionInput::Operations(vec![]),
            signed_envelope_xdr: Some("signed-xdr".to_string()),
            transaction_result_xdr: None,
        };

        let tx = TransactionRepoModel {
            id: "tx-1".to_string(),
            relayer_id: "relayer-1".to_string(),
            status: TransactionStatus::Failed,
            status_reason: Some("Bad sequence".to_string()),
            created_at: "2024-01-01".to_string(),
            sent_at: Some("2024-01-02".to_string()),
            confirmed_at: Some("2024-01-03".to_string()),
            valid_until: None,
            network_data: NetworkTransactionData::Stellar(stellar_data),
            priced_at: None,
            hashes: vec!["hash1".to_string(), "hash2".to_string()],
            network_type: NetworkType::Stellar,
            noop_count: None,
            is_canceled: None,
            delete_at: None,
            metadata: None,
        };

        let update_req = tx.create_reset_update_request().unwrap();

        // Check common fields
        assert_eq!(update_req.status, Some(TransactionStatus::Pending));
        assert_eq!(update_req.status_reason, None);
        assert_eq!(update_req.sent_at, None);
        assert_eq!(update_req.confirmed_at, None);
        assert_eq!(update_req.hashes, Some(vec![]));

        // Check that network data was reset
        if let Some(NetworkTransactionData::Stellar(reset_data)) = update_req.network_data {
            assert_eq!(reset_data.fee, None);
            assert_eq!(reset_data.sequence_number, None);
            assert_eq!(reset_data.hash, None);
            assert_eq!(reset_data.signed_envelope_xdr, None);
        } else {
            panic!("Expected Stellar network data");
        }
    }

    // Create a helper function to generate a sample EvmTransactionData for testing
    fn create_sample_evm_tx_data() -> EvmTransactionData {
        EvmTransactionData {
            gas_price: Some(20_000_000_000),
            gas_limit: Some(21000),
            nonce: Some(5),
            value: U256::from(1000000000000000000u128), // 1 ETH
            data: Some("0x".to_string()),
            from: "0x742d35Cc6634C0532925a3b844Bc454e4438f44e".to_string(),
            to: Some("0x5aAeb6053F3E94C9b9A09f33669435E7Ef1BeAed".to_string()),
            chain_id: 1,
            hash: None,
            signature: None,
            speed: None,
            max_fee_per_gas: None,
            max_priority_fee_per_gas: None,
            raw: None,
        }
    }

    // Tests for EvmTransactionData methods
    #[test]
    fn test_evm_tx_with_price_params() {
        let tx_data = create_sample_evm_tx_data();
        let price_params = PriceParams {
            gas_price: None,
            max_fee_per_gas: Some(30_000_000_000),
            max_priority_fee_per_gas: Some(2_000_000_000),
            is_min_bumped: None,
            extra_fee: None,
            total_cost: U256::ZERO,
        };

        let updated_tx = tx_data.with_price_params(price_params);

        assert_eq!(updated_tx.max_fee_per_gas, Some(30_000_000_000));
        assert_eq!(updated_tx.max_priority_fee_per_gas, Some(2_000_000_000));
    }

    #[test]
    fn test_evm_tx_with_gas_estimate() {
        let tx_data = create_sample_evm_tx_data();
        let new_gas_limit = 30000;

        let updated_tx = tx_data.with_gas_estimate(new_gas_limit);

        assert_eq!(updated_tx.gas_limit, Some(new_gas_limit));
    }

    #[test]
    fn test_evm_tx_with_nonce() {
        let tx_data = create_sample_evm_tx_data();
        let new_nonce = 10;

        let updated_tx = tx_data.with_nonce(new_nonce);

        assert_eq!(updated_tx.nonce, Some(new_nonce));
    }

    #[test]
    fn test_evm_tx_with_signed_transaction_data() {
        let tx_data = create_sample_evm_tx_data();

        let signature = EvmTransactionDataSignature {
            r: "r_value".to_string(),
            s: "s_value".to_string(),
            v: 27,
            sig: "signature_value".to_string(),
        };

        let signed_tx_response = SignTransactionResponseEvm {
            signature,
            hash: "0xabcdef1234567890".to_string(),
            raw: vec![1, 2, 3, 4, 5],
        };

        let updated_tx = tx_data.with_signed_transaction_data(signed_tx_response);

        assert_eq!(updated_tx.signature.as_ref().unwrap().r, "r_value");
        assert_eq!(updated_tx.signature.as_ref().unwrap().s, "s_value");
        assert_eq!(updated_tx.signature.as_ref().unwrap().v, 27);
        assert_eq!(updated_tx.hash, Some("0xabcdef1234567890".to_string()));
        assert_eq!(updated_tx.raw, Some(vec![1, 2, 3, 4, 5]));
    }

    #[test]
    fn test_evm_tx_to_address() {
        // Test with valid address
        let tx_data = create_sample_evm_tx_data();
        let address_result = tx_data.to_address();
        assert!(address_result.is_ok());
        let address_option = address_result.unwrap();
        assert!(address_option.is_some());
        assert_eq!(
            address_option.unwrap().to_string().to_lowercase(),
            "0x5aAeb6053F3E94C9b9A09f33669435E7Ef1BeAed".to_lowercase()
        );

        // Test with None address (contract creation)
        let mut contract_creation_tx = create_sample_evm_tx_data();
        contract_creation_tx.to = None;
        let address_result = contract_creation_tx.to_address();
        assert!(address_result.is_ok());
        assert!(address_result.unwrap().is_none());

        // Test with empty address string
        let mut empty_address_tx = create_sample_evm_tx_data();
        empty_address_tx.to = Some("".to_string());
        let address_result = empty_address_tx.to_address();
        assert!(address_result.is_ok());
        assert!(address_result.unwrap().is_none());

        // Test with invalid address
        let mut invalid_address_tx = create_sample_evm_tx_data();
        invalid_address_tx.to = Some("0xINVALID".to_string());
        let address_result = invalid_address_tx.to_address();
        assert!(address_result.is_err());
    }

    #[test]
    fn test_evm_tx_data_to_bytes() {
        // Test with valid hex data
        let mut tx_data = create_sample_evm_tx_data();
        tx_data.data = Some("0x1234".to_string());
        let bytes_result = tx_data.data_to_bytes();
        assert!(bytes_result.is_ok());
        assert_eq!(bytes_result.unwrap().as_ref(), &[0x12, 0x34]);

        // Test with empty data
        tx_data.data = Some("".to_string());
        assert!(tx_data.data_to_bytes().is_ok());

        // Test with None data
        tx_data.data = None;
        assert!(tx_data.data_to_bytes().is_ok());

        // Test with invalid hex data
        tx_data.data = Some("0xZZ".to_string());
        assert!(tx_data.data_to_bytes().is_err());
    }

    // Tests for EvmTransactionDataTrait implementation
    #[test]
    fn test_evm_tx_is_legacy() {
        let mut tx_data = create_sample_evm_tx_data();

        // Legacy transaction has gas_price
        assert!(tx_data.is_legacy());

        // Not legacy if gas_price is None
        tx_data.gas_price = None;
        assert!(!tx_data.is_legacy());
    }

    #[test]
    fn test_evm_tx_is_eip1559() {
        let mut tx_data = create_sample_evm_tx_data();

        // Not EIP-1559 initially
        assert!(!tx_data.is_eip1559());

        // Set EIP-1559 fields
        tx_data.max_fee_per_gas = Some(30_000_000_000);
        tx_data.max_priority_fee_per_gas = Some(2_000_000_000);
        assert!(tx_data.is_eip1559());

        // Not EIP-1559 if one field is missing
        tx_data.max_priority_fee_per_gas = None;
        assert!(!tx_data.is_eip1559());
    }

    #[test]
    fn test_evm_tx_is_speed() {
        let mut tx_data = create_sample_evm_tx_data();

        // No speed initially
        assert!(!tx_data.is_speed());

        // Set speed
        tx_data.speed = Some(Speed::Fast);
        assert!(tx_data.is_speed());
    }

    // Tests for NetworkTransactionData methods
    #[test]
    fn test_network_tx_data_get_evm_transaction_data() {
        let evm_tx_data = create_sample_evm_tx_data();
        let network_data = NetworkTransactionData::Evm(evm_tx_data.clone());

        // Should succeed for EVM data
        let result = network_data.get_evm_transaction_data();
        assert!(result.is_ok());
        assert_eq!(result.unwrap().chain_id, evm_tx_data.chain_id);

        // Should fail for non-EVM data
        let solana_data = NetworkTransactionData::Solana(SolanaTransactionData {
            transaction: Some("transaction_123".to_string()),
            ..Default::default()
        });
        assert!(solana_data.get_evm_transaction_data().is_err());
    }

    #[test]
    fn test_network_tx_data_get_solana_transaction_data() {
        let solana_tx_data = SolanaTransactionData {
            transaction: Some("transaction_123".to_string()),
            ..Default::default()
        };
        let network_data = NetworkTransactionData::Solana(solana_tx_data.clone());

        // Should succeed for Solana data
        let result = network_data.get_solana_transaction_data();
        assert!(result.is_ok());
        assert_eq!(result.unwrap().transaction, solana_tx_data.transaction);

        // Should fail for non-Solana data
        let evm_data = NetworkTransactionData::Evm(create_sample_evm_tx_data());
        assert!(evm_data.get_solana_transaction_data().is_err());
    }

    #[test]
    fn test_network_tx_data_get_stellar_transaction_data() {
        let stellar_tx_data = StellarTransactionData {
            source_account: "account123".to_string(),
            fee: Some(100),
            sequence_number: Some(5),
            memo: Some(MemoSpec::Text {
                value: "Test memo".to_string(),
            }),
            valid_until: Some("2025-01-01T00:00:00Z".to_string()),
            network_passphrase: "Test SDF Network ; September 2015".to_string(),
            signatures: Vec::new(),
            hash: Some("hash123".to_string()),
            simulation_transaction_data: None,
            transaction_input: TransactionInput::Operations(vec![OperationSpec::Payment {
                destination: "GCEZWKCA5VLDNRLN3RPRJMRZOX3Z6G5CHCGSNFHEYVXM3XOJMDS674JZ".to_string(),
                amount: 100000000, // 10 XLM in stroops
                asset: AssetSpec::Native,
            }]),
            signed_envelope_xdr: None,
            transaction_result_xdr: None,
        };
        let network_data = NetworkTransactionData::Stellar(stellar_tx_data.clone());

        // Should succeed for Stellar data
        let result = network_data.get_stellar_transaction_data();
        assert!(result.is_ok());
        assert_eq!(
            result.unwrap().source_account,
            stellar_tx_data.source_account
        );

        // Should fail for non-Stellar data
        let evm_data = NetworkTransactionData::Evm(create_sample_evm_tx_data());
        assert!(evm_data.get_stellar_transaction_data().is_err());
    }

    // Test for TryFrom<NetworkTransactionData> for TxLegacy
    #[test]
    fn test_try_from_network_tx_data_for_tx_legacy() {
        // Create a valid EVM transaction
        let evm_tx_data = create_sample_evm_tx_data();
        let network_data = NetworkTransactionData::Evm(evm_tx_data.clone());

        // Should convert successfully
        let result = TxLegacy::try_from(network_data);
        assert!(result.is_ok());
        let tx_legacy = result.unwrap();

        // Verify fields
        assert_eq!(tx_legacy.chain_id, Some(evm_tx_data.chain_id));
        assert_eq!(tx_legacy.nonce, evm_tx_data.nonce.unwrap());
        assert_eq!(tx_legacy.gas_limit, evm_tx_data.gas_limit.unwrap_or(21000));
        assert_eq!(tx_legacy.gas_price, evm_tx_data.gas_price.unwrap());
        assert_eq!(tx_legacy.value, evm_tx_data.value);

        // Should fail for non-EVM data
        let solana_data = NetworkTransactionData::Solana(SolanaTransactionData {
            transaction: Some("transaction_123".to_string()),
            ..Default::default()
        });
        assert!(TxLegacy::try_from(solana_data).is_err());
    }

    #[test]
    fn test_try_from_evm_tx_data_for_tx_legacy() {
        // Create a valid EVM transaction with legacy fields
        let evm_tx_data = create_sample_evm_tx_data();

        // Should convert successfully
        let result = TxLegacy::try_from(evm_tx_data.clone());
        assert!(result.is_ok());
        let tx_legacy = result.unwrap();

        // Verify fields
        assert_eq!(tx_legacy.chain_id, Some(evm_tx_data.chain_id));
        assert_eq!(tx_legacy.nonce, evm_tx_data.nonce.unwrap());
        assert_eq!(tx_legacy.gas_limit, evm_tx_data.gas_limit.unwrap_or(21000));
        assert_eq!(tx_legacy.gas_price, evm_tx_data.gas_price.unwrap());
        assert_eq!(tx_legacy.value, evm_tx_data.value);
    }

    fn dummy_signature() -> DecoratedSignature {
        let hint = SignatureHint([0; 4]);
        let bytes: Vec<u8> = vec![0u8; 64];
        let bytes_m: BytesM<64> = bytes.try_into().expect("BytesM conversion");
        DecoratedSignature {
            hint,
            signature: Signature(bytes_m),
        }
    }

    fn test_stellar_tx_data() -> StellarTransactionData {
        StellarTransactionData {
            source_account: "GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF".to_string(),
            fee: Some(100),
            sequence_number: Some(1),
            memo: None,
            valid_until: None,
            network_passphrase: "Test SDF Network ; September 2015".to_string(),
            signatures: Vec::new(),
            hash: None,
            simulation_transaction_data: None,
            transaction_input: TransactionInput::Operations(vec![OperationSpec::Payment {
                destination: "GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF".to_string(),
                amount: 1000,
                asset: AssetSpec::Native,
            }]),
            signed_envelope_xdr: None,
            transaction_result_xdr: None,
        }
    }

    #[test]
    fn test_with_sequence_number() {
        let tx = test_stellar_tx_data();
        let updated = tx.with_sequence_number(42);
        assert_eq!(updated.sequence_number, Some(42));
    }

    #[test]
    fn test_stellar_sequence_number_serializes_as_string() {
        // sequence_number must serialize as a JSON string so it survives a
        // Redis/Lua cjson decode->encode round-trip. Lua 5.1 (bundled by
        // Redis) has no integer type, so a large i64 stored as a bare JSON
        // number is re-emitted as a float (e.g. 643918676885760.0), which
        // then fails to deserialize back into i64. A quoted string is opaque
        // to cjson and round-trips untouched.
        let mut tx = test_stellar_tx_data();
        tx.sequence_number = Some(643918676885760);

        let json = serde_json::to_string(&tx).unwrap();

        assert!(
            json.contains(r#""sequence_number":"643918676885760""#),
            "sequence_number should serialize as a string, got: {json}"
        );
    }

    #[test]
    fn test_stellar_sequence_number_deserializes_from_corrupted_float() {
        // Regression for the GCP crash: transactions already stored in Redis
        // hold sequence_number as a float (643918676885760.0) after a cjson
        // round-trip. Deserialization must recover the integer value rather
        // than erroring with "invalid type: floating point ..., expected i64".
        let mut value = serde_json::to_value(test_stellar_tx_data()).unwrap();
        value["sequence_number"] = serde_json::json!(643918676885760.0);
        let json = serde_json::to_string(&value).unwrap();

        let tx: StellarTransactionData = serde_json::from_str(&json).unwrap();

        assert_eq!(tx.sequence_number, Some(643918676885760));
    }

    #[test]
    fn test_stellar_sequence_number_deserializes_from_legacy_integer() {
        // Backward compat: records written before this fix hold a bare integer.
        // (Passes today; guards us against regressing the legacy on-disk form.)
        let mut value = serde_json::to_value(test_stellar_tx_data()).unwrap();
        value["sequence_number"] = serde_json::json!(643918676885760_i64);
        let json = serde_json::to_string(&value).unwrap();

        let tx: StellarTransactionData = serde_json::from_str(&json).unwrap();

        assert_eq!(tx.sequence_number, Some(643918676885760));
    }

    fn signed_xdr_tx_data(max_fee: i64) -> StellarTransactionData {
        let mut tx = test_stellar_tx_data();
        tx.transaction_input = TransactionInput::SignedXdr {
            xdr: "AAAA".to_string(),
            max_fee,
        };
        tx
    }

    #[test]
    fn test_stellar_signed_xdr_max_fee_serializes_as_string() {
        // SignedXdr.max_fee is an i64 stored in Redis and re-encoded by the
        // partial_update Lua script, so it has the same cjson float-corruption
        // exposure as sequence_number and must serialize as a string too.
        let json = serde_json::to_string(&signed_xdr_tx_data(643918676885760)).unwrap();

        assert!(
            json.contains(r#""max_fee":"643918676885760""#),
            "max_fee should serialize as a string, got: {json}"
        );
    }

    #[test]
    fn test_stellar_signed_xdr_max_fee_deserializes_from_corrupted_float() {
        // Regression: a SignedXdr tx whose max_fee was floatified by a cjson
        // round-trip must still deserialize.
        let mut value = serde_json::to_value(signed_xdr_tx_data(643918676885760)).unwrap();
        value["transaction_input"]["SignedXdr"]["max_fee"] = serde_json::json!(643918676885760.0);
        let json = serde_json::to_string(&value).unwrap();

        let tx: StellarTransactionData = serde_json::from_str(&json).unwrap();

        match tx.transaction_input {
            TransactionInput::SignedXdr { max_fee, .. } => assert_eq!(max_fee, 643918676885760),
            other => panic!("expected SignedXdr, got {other:?}"),
        }
    }

    #[test]
    fn test_stellar_signed_xdr_max_fee_deserializes_from_legacy_integer() {
        // Backward compat with bare-integer records written before this fix.
        let mut value = serde_json::to_value(signed_xdr_tx_data(35014)).unwrap();
        value["transaction_input"]["SignedXdr"]["max_fee"] = serde_json::json!(35014_i64);
        let json = serde_json::to_string(&value).unwrap();

        let tx: StellarTransactionData = serde_json::from_str(&json).unwrap();

        match tx.transaction_input {
            TransactionInput::SignedXdr { max_fee, .. } => assert_eq!(max_fee, 35014),
            other => panic!("expected SignedXdr, got {other:?}"),
        }
    }

    #[test]
    fn test_get_envelope_for_simulation() {
        let tx = test_stellar_tx_data();
        let env = tx.get_envelope_for_simulation();
        assert!(env.is_ok());
        let env = env.unwrap();
        // Should be a TransactionV1Envelope with no signatures
        match env {
            soroban_rs::xdr::TransactionEnvelope::Tx(tx_env) => {
                assert_eq!(tx_env.signatures.len(), 0);
            }
            _ => {
                panic!("Expected TransactionEnvelope::Tx variant");
            }
        }
    }

    #[test]
    fn test_get_envelope_for_submission() {
        let mut tx = test_stellar_tx_data();
        tx.signatures.push(dummy_signature());
        let env = tx.get_envelope_for_submission();
        assert!(env.is_ok());
        let env = env.unwrap();
        match env {
            soroban_rs::xdr::TransactionEnvelope::Tx(tx_env) => {
                assert_eq!(tx_env.signatures.len(), 1);
            }
            _ => {
                panic!("Expected TransactionEnvelope::Tx variant");
            }
        }
    }

    #[test]
    fn test_attach_signature() {
        let tx = test_stellar_tx_data();
        let sig = dummy_signature();
        let updated = tx.attach_signature(sig.clone());
        assert_eq!(updated.signatures.len(), 1);
        assert_eq!(updated.signatures[0], sig);
    }

    #[test]
    fn test_with_hash() {
        let tx = test_stellar_tx_data();
        let updated = tx.with_hash("hash123".to_string());
        assert_eq!(updated.hash, Some("hash123".to_string()));
    }

    #[test]
    fn test_evm_tx_for_replacement() {
        let old_data = create_sample_evm_tx_data();
        let new_request = EvmTransactionRequest {
            to: Some("0xNewRecipient".to_string()),
            value: U256::from(2000000000000000000u64), // 2 ETH
            data: Some("0xNewData".to_string()),
            gas_limit: Some(25000),
            gas_price: Some(30000000000), // 30 Gwei (should be ignored)
            max_fee_per_gas: Some(40000000000), // Should be ignored
            max_priority_fee_per_gas: Some(2000000000), // Should be ignored
            speed: Some(Speed::Fast),
            valid_until: None,
        };

        let result = EvmTransactionData::for_replacement(&old_data, &new_request);

        // Should preserve old data fields
        assert_eq!(result.chain_id, old_data.chain_id);
        assert_eq!(result.from, old_data.from);
        assert_eq!(result.nonce, old_data.nonce);

        // Should use new request fields
        assert_eq!(result.to, new_request.to);
        assert_eq!(result.value, new_request.value);
        assert_eq!(result.data, new_request.data);
        assert_eq!(result.gas_limit, new_request.gas_limit);
        assert_eq!(result.speed, new_request.speed);

        // Should clear all pricing fields (regardless of what's in the request)
        assert_eq!(result.gas_price, None);
        assert_eq!(result.max_fee_per_gas, None);
        assert_eq!(result.max_priority_fee_per_gas, None);

        // Should reset signing fields
        assert_eq!(result.signature, None);
        assert_eq!(result.hash, None);
        assert_eq!(result.raw, None);
    }

    #[test]
    fn test_transaction_repo_model_validate() {
        let transaction = TransactionRepoModel::default();
        let result = transaction.validate();
        assert!(result.is_ok());
    }

    #[test]
    fn test_try_from_network_transaction_request_evm() {
        use crate::models::{NetworkRepoModel, NetworkType, RelayerRepoModel};

        let evm_request = NetworkTransactionRequest::Evm(EvmTransactionRequest {
            to: Some("0x742d35Cc6634C0532925a3b844Bc454e4438f44e".to_string()),
            value: U256::from(1000000000000000000u128),
            data: Some("0x1234".to_string()),
            gas_limit: Some(21000),
            gas_price: Some(20000000000),
            max_fee_per_gas: None,
            max_priority_fee_per_gas: None,
            speed: Some(Speed::Fast),
            valid_until: Some("2024-12-31T23:59:59Z".to_string()),
        });

        let relayer_model = RelayerRepoModel {
            id: "relayer-id".to_string(),
            name: "Test Relayer".to_string(),
            network: "network-id".to_string(),
            paused: false,
            network_type: NetworkType::Evm,
            signer_id: "signer-id".to_string(),
            policies: RelayerNetworkPolicy::Evm(RelayerEvmPolicy::default()),
            address: "0x742d35Cc6634C0532925a3b844Bc454e4438f44e".to_string(),
            notification_id: None,
            system_disabled: false,
            custom_rpc_urls: None,
            ..Default::default()
        };

        let network_model = NetworkRepoModel {
            id: "evm:ethereum".to_string(),
            name: "ethereum".to_string(),
            network_type: NetworkType::Evm,
            config: NetworkConfigData::Evm(EvmNetworkConfig {
                common: NetworkConfigCommon {
                    network: "ethereum".to_string(),
                    from: None,
                    rpc_urls: Some(vec![crate::models::RpcConfig::new(
                        "https://mainnet.infura.io".to_string(),
                    )]),
                    explorer_urls: Some(vec!["https://etherscan.io".to_string()]),
                    average_blocktime_ms: Some(12000),
                    is_testnet: Some(false),
                    tags: Some(vec!["mainnet".to_string()]),
                },
                chain_id: Some(1),
                required_confirmations: Some(12),
                features: None,
                symbol: Some("ETH".to_string()),
                gas_price_cache: None,
            }),
        };

        let result = TransactionRepoModel::try_from((&evm_request, &relayer_model, &network_model));
        assert!(result.is_ok());
        let transaction = result.unwrap();

        assert_eq!(transaction.relayer_id, relayer_model.id);
        assert_eq!(transaction.status, TransactionStatus::Pending);
        assert_eq!(transaction.network_type, NetworkType::Evm);
        assert_eq!(
            transaction.valid_until,
            Some("2024-12-31T23:59:59Z".to_string())
        );
        assert!(transaction.is_canceled == Some(false));

        if let NetworkTransactionData::Evm(evm_data) = transaction.network_data {
            assert_eq!(evm_data.from, relayer_model.address);
            assert_eq!(
                evm_data.to,
                Some("0x742d35Cc6634C0532925a3b844Bc454e4438f44e".to_string())
            );
            assert_eq!(evm_data.value, U256::from(1000000000000000000u128));
            assert_eq!(evm_data.chain_id, 1);
            assert_eq!(evm_data.gas_limit, Some(21000));
            assert_eq!(evm_data.gas_price, Some(20000000000));
            assert_eq!(evm_data.speed, Some(Speed::Fast));
        } else {
            panic!("Expected EVM transaction data");
        }
    }

    #[test]
    fn test_try_from_network_transaction_request_solana() {
        use crate::models::{
            NetworkRepoModel, NetworkTransactionRequest, NetworkType, RelayerRepoModel,
        };

        let solana_request = NetworkTransactionRequest::Solana(
            crate::models::transaction::request::solana::SolanaTransactionRequest {
                transaction: Some(EncodedSerializedTransaction::new(
                    "transaction_123".to_string(),
                )),
                instructions: None,
                valid_until: None,
            },
        );

        let relayer_model = RelayerRepoModel {
            id: "relayer-id".to_string(),
            name: "Test Solana Relayer".to_string(),
            network: "network-id".to_string(),
            paused: false,
            network_type: NetworkType::Solana,
            signer_id: "signer-id".to_string(),
            policies: RelayerNetworkPolicy::Solana(RelayerSolanaPolicy::default()),
            address: "solana_address".to_string(),
            notification_id: None,
            system_disabled: false,
            custom_rpc_urls: None,
            ..Default::default()
        };

        let network_model = NetworkRepoModel {
            id: "solana:mainnet".to_string(),
            name: "mainnet".to_string(),
            network_type: NetworkType::Solana,
            config: NetworkConfigData::Solana(SolanaNetworkConfig {
                common: NetworkConfigCommon {
                    network: "mainnet".to_string(),
                    from: None,
                    rpc_urls: Some(vec![crate::models::RpcConfig::new(
                        "https://api.mainnet-beta.solana.com".to_string(),
                    )]),
                    explorer_urls: Some(vec!["https://explorer.solana.com".to_string()]),
                    average_blocktime_ms: Some(400),
                    is_testnet: Some(false),
                    tags: Some(vec!["mainnet".to_string()]),
                },
            }),
        };

        let result =
            TransactionRepoModel::try_from((&solana_request, &relayer_model, &network_model));
        assert!(result.is_ok());
        let transaction = result.unwrap();

        assert_eq!(transaction.relayer_id, relayer_model.id);
        assert_eq!(transaction.status, TransactionStatus::Pending);
        assert_eq!(transaction.network_type, NetworkType::Solana);
        assert_eq!(transaction.valid_until, None);

        if let NetworkTransactionData::Solana(solana_data) = transaction.network_data {
            assert_eq!(solana_data.transaction, Some("transaction_123".to_string()));
            assert_eq!(solana_data.signature, None);
        } else {
            panic!("Expected Solana transaction data");
        }
    }

    #[test]
    fn test_try_from_network_transaction_request_stellar() {
        use crate::models::transaction::request::stellar::StellarTransactionRequest;
        use crate::models::{
            NetworkRepoModel, NetworkTransactionRequest, NetworkType, RelayerRepoModel,
        };

        let stellar_request = NetworkTransactionRequest::Stellar(StellarTransactionRequest {
            source_account: Some(
                "GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF".to_string(),
            ),
            network: "mainnet".to_string(),
            operations: Some(vec![OperationSpec::Payment {
                destination: "GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF".to_string(),
                amount: 1000000,
                asset: AssetSpec::Native,
            }]),
            memo: Some(MemoSpec::Text {
                value: "Test memo".to_string(),
            }),
            valid_until: Some("2024-12-31T23:59:59Z".to_string()),
            transaction_xdr: None,
            fee_bump: None,
            max_fee: None,
            signed_auth_entry: None,
        });

        let relayer_model = RelayerRepoModel {
            id: "relayer-id".to_string(),
            name: "Test Stellar Relayer".to_string(),
            network: "network-id".to_string(),
            paused: false,
            network_type: NetworkType::Stellar,
            signer_id: "signer-id".to_string(),
            policies: RelayerNetworkPolicy::Stellar(RelayerStellarPolicy::default()),
            address: "stellar_address".to_string(),
            notification_id: None,
            system_disabled: false,
            custom_rpc_urls: None,
            ..Default::default()
        };

        let network_model = NetworkRepoModel {
            id: "stellar:mainnet".to_string(),
            name: "mainnet".to_string(),
            network_type: NetworkType::Stellar,
            config: NetworkConfigData::Stellar(StellarNetworkConfig {
                common: NetworkConfigCommon {
                    network: "mainnet".to_string(),
                    from: None,
                    rpc_urls: Some(vec![crate::models::RpcConfig::new(
                        "https://horizon.stellar.org".to_string(),
                    )]),
                    explorer_urls: Some(vec!["https://stellarchain.io".to_string()]),
                    average_blocktime_ms: Some(5000),
                    is_testnet: Some(false),
                    tags: Some(vec!["mainnet".to_string()]),
                },
                passphrase: Some("Public Global Stellar Network ; September 2015".to_string()),
                horizon_url: Some("https://horizon.stellar.org".to_string()),
            }),
        };

        let result =
            TransactionRepoModel::try_from((&stellar_request, &relayer_model, &network_model));
        assert!(result.is_ok());
        let transaction = result.unwrap();

        assert_eq!(transaction.relayer_id, relayer_model.id);
        assert_eq!(transaction.status, TransactionStatus::Pending);
        assert_eq!(transaction.network_type, NetworkType::Stellar);
        // valid_until should be set from the request
        assert_eq!(
            transaction.valid_until,
            Some("2024-12-31T23:59:59Z".to_string())
        );

        if let NetworkTransactionData::Stellar(stellar_data) = transaction.network_data {
            assert_eq!(
                stellar_data.source_account,
                "GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF"
            );
            // Check that transaction_input contains the operations
            if let TransactionInput::Operations(ops) = &stellar_data.transaction_input {
                assert_eq!(ops.len(), 1);
                if let OperationSpec::Payment {
                    destination,
                    amount,
                    asset,
                } = &ops[0]
                {
                    assert_eq!(
                        destination,
                        "GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF"
                    );
                    assert_eq!(amount, &1000000);
                    assert_eq!(asset, &AssetSpec::Native);
                } else {
                    panic!("Expected Payment operation");
                }
            } else {
                panic!("Expected Operations transaction input");
            }
            assert_eq!(
                stellar_data.memo,
                Some(MemoSpec::Text {
                    value: "Test memo".to_string()
                })
            );
            assert_eq!(
                stellar_data.valid_until,
                Some("2024-12-31T23:59:59Z".to_string())
            );
            assert_eq!(stellar_data.signatures.len(), 0);
            assert_eq!(stellar_data.hash, None);
            assert_eq!(stellar_data.fee, None);
            assert_eq!(stellar_data.sequence_number, None);
        } else {
            panic!("Expected Stellar transaction data");
        }
    }

    #[test]
    fn test_try_from_network_transaction_data_for_tx_eip1559() {
        // Create a valid EVM transaction with EIP-1559 fields
        let mut evm_tx_data = create_sample_evm_tx_data();
        evm_tx_data.max_fee_per_gas = Some(30_000_000_000);
        evm_tx_data.max_priority_fee_per_gas = Some(2_000_000_000);
        let network_data = NetworkTransactionData::Evm(evm_tx_data.clone());

        // Should convert successfully
        let result = TxEip1559::try_from(network_data);
        assert!(result.is_ok());
        let tx_eip1559 = result.unwrap();

        // Verify fields
        assert_eq!(tx_eip1559.chain_id, evm_tx_data.chain_id);
        assert_eq!(tx_eip1559.nonce, evm_tx_data.nonce.unwrap());
        assert_eq!(tx_eip1559.gas_limit, evm_tx_data.gas_limit.unwrap_or(21000));
        assert_eq!(
            tx_eip1559.max_fee_per_gas,
            evm_tx_data.max_fee_per_gas.unwrap()
        );
        assert_eq!(
            tx_eip1559.max_priority_fee_per_gas,
            evm_tx_data.max_priority_fee_per_gas.unwrap()
        );
        assert_eq!(tx_eip1559.value, evm_tx_data.value);
        assert!(tx_eip1559.access_list.0.is_empty());

        // Should fail for non-EVM data
        let solana_data = NetworkTransactionData::Solana(SolanaTransactionData {
            transaction: Some("transaction_123".to_string()),
            ..Default::default()
        });
        assert!(TxEip1559::try_from(solana_data).is_err());
    }

    #[test]
    fn test_evm_transaction_data_defaults() {
        let default_data = EvmTransactionData::default();

        assert_eq!(
            default_data.from,
            "0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266"
        );
        assert_eq!(
            default_data.to,
            Some("0x70997970C51812dc3A010C7d01b50e0d17dc79C8".to_string())
        );
        assert_eq!(default_data.gas_price, Some(20000000000));
        assert_eq!(default_data.value, U256::from(1000000000000000000u128));
        assert_eq!(default_data.data, Some("0x".to_string()));
        assert_eq!(default_data.nonce, Some(1));
        assert_eq!(default_data.chain_id, 1);
        assert_eq!(default_data.gas_limit, Some(21000));
        assert_eq!(default_data.hash, None);
        assert_eq!(default_data.signature, None);
        assert_eq!(default_data.speed, None);
        assert_eq!(default_data.max_fee_per_gas, None);
        assert_eq!(default_data.max_priority_fee_per_gas, None);
        assert_eq!(default_data.raw, None);
    }

    #[test]
    fn test_transaction_repo_model_defaults() {
        let default_model = TransactionRepoModel::default();

        assert_eq!(default_model.id, "00000000-0000-0000-0000-000000000001");
        assert_eq!(
            default_model.relayer_id,
            "00000000-0000-0000-0000-000000000002"
        );
        assert_eq!(default_model.status, TransactionStatus::Pending);
        assert_eq!(default_model.created_at, "2023-01-01T00:00:00Z");
        assert_eq!(default_model.status_reason, None);
        assert_eq!(default_model.sent_at, None);
        assert_eq!(default_model.confirmed_at, None);
        assert_eq!(default_model.valid_until, None);
        assert_eq!(default_model.delete_at, None);
        assert_eq!(default_model.network_type, NetworkType::Evm);
        assert_eq!(default_model.priced_at, None);
        assert_eq!(default_model.hashes.len(), 0);
        assert_eq!(default_model.noop_count, None);
        assert_eq!(default_model.is_canceled, Some(false));
    }

    #[test]
    fn test_evm_tx_for_replacement_with_speed_fallback() {
        let mut old_data = create_sample_evm_tx_data();
        old_data.speed = Some(Speed::SafeLow);

        // Request with no speed - should use old data's speed
        let new_request = EvmTransactionRequest {
            to: Some("0xNewRecipient".to_string()),
            value: U256::from(2000000000000000000u64),
            data: Some("0xNewData".to_string()),
            gas_limit: Some(25000),
            gas_price: None,
            max_fee_per_gas: None,
            max_priority_fee_per_gas: None,
            speed: None,
            valid_until: None,
        };

        let result = EvmTransactionData::for_replacement(&old_data, &new_request);
        assert_eq!(result.speed, Some(Speed::SafeLow));

        // Old data with no speed - should use default
        let mut old_data_no_speed = create_sample_evm_tx_data();
        old_data_no_speed.speed = None;

        let result2 = EvmTransactionData::for_replacement(&old_data_no_speed, &new_request);
        assert_eq!(result2.speed, Some(DEFAULT_TRANSACTION_SPEED));
    }

    #[test]
    fn test_transaction_status_serialization() {
        use serde_json;

        // Test serialization of different status values
        assert_eq!(
            serde_json::to_string(&TransactionStatus::Pending).unwrap(),
            "\"pending\""
        );
        assert_eq!(
            serde_json::to_string(&TransactionStatus::Sent).unwrap(),
            "\"sent\""
        );
        assert_eq!(
            serde_json::to_string(&TransactionStatus::Mined).unwrap(),
            "\"mined\""
        );
        assert_eq!(
            serde_json::to_string(&TransactionStatus::Failed).unwrap(),
            "\"failed\""
        );
        assert_eq!(
            serde_json::to_string(&TransactionStatus::Confirmed).unwrap(),
            "\"confirmed\""
        );
        assert_eq!(
            serde_json::to_string(&TransactionStatus::Canceled).unwrap(),
            "\"canceled\""
        );
        assert_eq!(
            serde_json::to_string(&TransactionStatus::Submitted).unwrap(),
            "\"submitted\""
        );
        assert_eq!(
            serde_json::to_string(&TransactionStatus::Expired).unwrap(),
            "\"expired\""
        );
    }

    #[test]
    fn test_evm_tx_contract_creation() {
        // Test transaction data for contract creation (no 'to' address)
        let mut tx_data = create_sample_evm_tx_data();
        tx_data.to = None;

        let tx_legacy = TxLegacy::try_from(&tx_data).unwrap();
        assert_eq!(tx_legacy.to, TxKind::Create);

        let tx_eip1559 = TxEip1559::try_from(&tx_data).unwrap();
        assert_eq!(tx_eip1559.to, TxKind::Create);
    }

    #[test]
    fn test_evm_tx_default_values_in_conversion() {
        // Test conversion with missing nonce and gas price
        let mut tx_data = create_sample_evm_tx_data();
        tx_data.nonce = None;
        tx_data.gas_price = None;
        tx_data.max_fee_per_gas = None;
        tx_data.max_priority_fee_per_gas = None;

        let tx_legacy = TxLegacy::try_from(&tx_data).unwrap();
        assert_eq!(tx_legacy.nonce, 0); // Default nonce
        assert_eq!(tx_legacy.gas_price, 0); // Default gas price

        let tx_eip1559 = TxEip1559::try_from(&tx_data).unwrap();
        assert_eq!(tx_eip1559.nonce, 0); // Default nonce
        assert_eq!(tx_eip1559.max_fee_per_gas, 0); // Default max fee
        assert_eq!(tx_eip1559.max_priority_fee_per_gas, 0); // Default max priority fee
    }

    // Helper function to create test network and relayer models
    fn test_models() -> (NetworkRepoModel, RelayerRepoModel) {
        use crate::config::{NetworkConfigCommon, StellarNetworkConfig};
        use crate::constants::DEFAULT_STELLAR_MIN_BALANCE;

        let network_config = NetworkConfigData::Stellar(StellarNetworkConfig {
            common: NetworkConfigCommon {
                network: "testnet".to_string(),
                from: None,
                rpc_urls: Some(vec![crate::models::RpcConfig::new(
                    "https://test.stellar.org".to_string(),
                )]),
                explorer_urls: None,
                average_blocktime_ms: Some(5000), // 5 seconds for Stellar
                is_testnet: Some(true),
                tags: None,
            },
            passphrase: Some("Test SDF Network ; September 2015".to_string()),
            horizon_url: Some("https://horizon-testnet.stellar.org".to_string()),
        });

        let network_model = NetworkRepoModel {
            id: "stellar:testnet".to_string(),
            name: "testnet".to_string(),
            network_type: NetworkType::Stellar,
            config: network_config,
        };

        let relayer_model = RelayerRepoModel {
            id: "test-relayer".to_string(),
            name: "Test Relayer".to_string(),
            network: "stellar:testnet".to_string(),
            paused: false,
            network_type: NetworkType::Stellar,
            signer_id: "test-signer".to_string(),
            policies: RelayerNetworkPolicy::Stellar(RelayerStellarPolicy {
                max_fee: None,
                timeout_seconds: None,
                min_balance: Some(DEFAULT_STELLAR_MIN_BALANCE),
                concurrent_transactions: None,
                allowed_tokens: None,
                fee_payment_strategy: Some(StellarFeePaymentStrategy::Relayer),
                slippage_percentage: None,
                fee_margin_percentage: None,
                swap_config: None,
            }),
            address: "GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF".to_string(),
            notification_id: None,
            system_disabled: false,
            custom_rpc_urls: None,
            ..Default::default()
        };

        (network_model, relayer_model)
    }

    #[test]
    fn test_stellar_transaction_data_serialization_roundtrip() {
        use crate::models::transaction::stellar::asset::AssetSpec;
        use crate::models::transaction::stellar::operation::OperationSpec;
        use soroban_rs::xdr::{BytesM, Signature, SignatureHint};

        // Create a dummy signature
        let hint = SignatureHint([1, 2, 3, 4]);
        let sig_bytes: Vec<u8> = vec![5u8; 64];
        let sig_bytes_m: BytesM<64> = sig_bytes.try_into().unwrap();
        let dummy_signature = DecoratedSignature {
            hint,
            signature: Signature(sig_bytes_m),
        };

        // Create a StellarTransactionData with operations, signatures, and other fields
        let original_data = StellarTransactionData {
            source_account: "GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF".to_string(),
            fee: Some(100),
            sequence_number: Some(12345),
            memo: None,
            valid_until: None,
            network_passphrase: "Test SDF Network ; September 2015".to_string(),
            signatures: vec![dummy_signature.clone()],
            hash: Some("test-hash".to_string()),
            simulation_transaction_data: Some("simulation-data".to_string()),
            transaction_input: TransactionInput::Operations(vec![OperationSpec::Payment {
                destination: "GBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB".to_string(),
                amount: 1000,
                asset: AssetSpec::Native,
            }]),
            signed_envelope_xdr: Some("signed-xdr-data".to_string()),
            transaction_result_xdr: None,
        };

        // Serialize to JSON
        let json = serde_json::to_string(&original_data).expect("Failed to serialize");

        // Deserialize from JSON
        let deserialized_data: StellarTransactionData =
            serde_json::from_str(&json).expect("Failed to deserialize");

        // Verify that transaction_input is preserved
        match (
            &original_data.transaction_input,
            &deserialized_data.transaction_input,
        ) {
            (TransactionInput::Operations(orig_ops), TransactionInput::Operations(deser_ops)) => {
                assert_eq!(orig_ops.len(), deser_ops.len());
                assert_eq!(orig_ops, deser_ops);
            }
            _ => panic!("Transaction input type mismatch"),
        }

        // Verify signatures are preserved
        assert_eq!(
            original_data.signatures.len(),
            deserialized_data.signatures.len()
        );
        assert_eq!(original_data.signatures, deserialized_data.signatures);

        // Verify other fields are preserved
        assert_eq!(
            original_data.source_account,
            deserialized_data.source_account
        );
        assert_eq!(original_data.fee, deserialized_data.fee);
        assert_eq!(
            original_data.sequence_number,
            deserialized_data.sequence_number
        );
        assert_eq!(
            original_data.network_passphrase,
            deserialized_data.network_passphrase
        );
        assert_eq!(original_data.hash, deserialized_data.hash);
        assert_eq!(
            original_data.simulation_transaction_data,
            deserialized_data.simulation_transaction_data
        );
        assert_eq!(
            original_data.signed_envelope_xdr,
            deserialized_data.signed_envelope_xdr
        );
    }

    #[test]
    fn test_stellar_xdr_transaction_input_conversion() {
        let (network_model, relayer_model) = test_models();

        // Test case 1: Operations mode (existing behavior)
        let stellar_request = StellarTransactionRequest {
            source_account: Some(
                "GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF".to_string(),
            ),
            network: "testnet".to_string(),
            operations: Some(vec![OperationSpec::Payment {
                destination: "GBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB".to_string(),
                amount: 1000000,
                asset: AssetSpec::Native,
            }]),
            memo: None,
            valid_until: None,
            transaction_xdr: None,
            fee_bump: None,
            max_fee: None,
            signed_auth_entry: None,
        };

        let request = NetworkTransactionRequest::Stellar(stellar_request);
        let result = TransactionRepoModel::try_from((&request, &relayer_model, &network_model));
        assert!(result.is_ok());

        let tx_model = result.unwrap();
        if let NetworkTransactionData::Stellar(ref stellar_data) = tx_model.network_data {
            assert!(matches!(
                stellar_data.transaction_input,
                TransactionInput::Operations(_)
            ));
        } else {
            panic!("Expected Stellar transaction data");
        }

        // Test case 2: Unsigned XDR mode
        // This is a valid unsigned transaction created with stellar CLI
        let unsigned_xdr = "AAAAAgAAAACige4lTdwSB/sto4SniEdJ2kOa2X65s5bqkd40J4DjSwAAAGQAAHAkAAAADgAAAAAAAAAAAAAAAQAAAAAAAAABAAAAAKKB7iVN3BIH+y2jhKeIR0naQ5rZfrmzluqR3jQngONLAAAAAAAAAAAAD0JAAAAAAAAAAAA=";
        let stellar_request = StellarTransactionRequest {
            source_account: None,
            network: "testnet".to_string(),
            operations: Some(vec![]),
            memo: None,
            valid_until: None,
            transaction_xdr: Some(unsigned_xdr.to_string()),
            fee_bump: None,
            max_fee: None,
            signed_auth_entry: None,
        };

        let request = NetworkTransactionRequest::Stellar(stellar_request);
        let result = TransactionRepoModel::try_from((&request, &relayer_model, &network_model));
        assert!(result.is_ok());

        let tx_model = result.unwrap();
        if let NetworkTransactionData::Stellar(ref stellar_data) = tx_model.network_data {
            assert!(matches!(
                stellar_data.transaction_input,
                TransactionInput::UnsignedXdr(_)
            ));
        } else {
            panic!("Expected Stellar transaction data");
        }

        // Test case 3: Signed XDR with fee_bump
        // Create a signed XDR by duplicating the test logic from xdr_tests
        let signed_xdr = {
            use soroban_rs::xdr::{Limits, TransactionEnvelope, TransactionV1Envelope, WriteXdr};
            use stellar_strkey::ed25519::PublicKey;

            // Use the same transaction structure but add a dummy signature
            let source_pk =
                PublicKey::from_string("GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF")
                    .unwrap();
            let dest_pk =
                PublicKey::from_string("GCEZWKCA5VLDNRLN3RPRJMRZOX3Z6G5CHCGSNFHEYVXM3XOJMDS674JZ")
                    .unwrap();

            let payment_op = soroban_rs::xdr::PaymentOp {
                destination: soroban_rs::xdr::MuxedAccount::Ed25519(soroban_rs::xdr::Uint256(
                    dest_pk.0,
                )),
                asset: soroban_rs::xdr::Asset::Native,
                amount: 1000000,
            };

            let operation = soroban_rs::xdr::Operation {
                source_account: None,
                body: soroban_rs::xdr::OperationBody::Payment(payment_op),
            };

            let operations: soroban_rs::xdr::VecM<soroban_rs::xdr::Operation, 100> =
                vec![operation].try_into().unwrap();

            let tx = soroban_rs::xdr::Transaction {
                source_account: soroban_rs::xdr::MuxedAccount::Ed25519(soroban_rs::xdr::Uint256(
                    source_pk.0,
                )),
                fee: 100,
                seq_num: soroban_rs::xdr::SequenceNumber(1),
                cond: soroban_rs::xdr::Preconditions::None,
                memo: soroban_rs::xdr::Memo::None,
                operations,
                ext: soroban_rs::xdr::TransactionExt::V0,
            };

            // Add a dummy signature
            let hint = soroban_rs::xdr::SignatureHint([0; 4]);
            let sig_bytes: Vec<u8> = vec![0u8; 64];
            let sig_bytes_m: soroban_rs::xdr::BytesM<64> = sig_bytes.try_into().unwrap();
            let sig = soroban_rs::xdr::DecoratedSignature {
                hint,
                signature: soroban_rs::xdr::Signature(sig_bytes_m),
            };

            let envelope = TransactionV1Envelope {
                tx,
                signatures: vec![sig].try_into().unwrap(),
            };

            let tx_envelope = TransactionEnvelope::Tx(envelope);
            tx_envelope.to_xdr_base64(Limits::none()).unwrap()
        };
        let stellar_request = StellarTransactionRequest {
            source_account: None,
            network: "testnet".to_string(),
            operations: Some(vec![]),
            memo: None,
            valid_until: None,
            transaction_xdr: Some(signed_xdr.to_string()),
            fee_bump: Some(true),
            max_fee: Some(20000000),
            signed_auth_entry: None,
        };

        let request = NetworkTransactionRequest::Stellar(stellar_request);
        let result = TransactionRepoModel::try_from((&request, &relayer_model, &network_model));
        assert!(result.is_ok());

        let tx_model = result.unwrap();
        if let NetworkTransactionData::Stellar(ref stellar_data) = tx_model.network_data {
            match &stellar_data.transaction_input {
                TransactionInput::SignedXdr { xdr, max_fee } => {
                    assert_eq!(xdr, &signed_xdr);
                    assert_eq!(*max_fee, 20000000);
                }
                _ => panic!("Expected SignedXdr transaction input"),
            }
        } else {
            panic!("Expected Stellar transaction data");
        }

        // Test case 4: Signed XDR without fee_bump should fail
        let stellar_request = StellarTransactionRequest {
            source_account: None,
            network: "testnet".to_string(),
            operations: Some(vec![]),
            memo: None,
            valid_until: None,
            transaction_xdr: Some(signed_xdr.clone()),
            fee_bump: None,
            max_fee: None,
            signed_auth_entry: None,
        };

        let request = NetworkTransactionRequest::Stellar(stellar_request);
        let result = TransactionRepoModel::try_from((&request, &relayer_model, &network_model));
        assert!(result.is_err());
        assert!(result
            .unwrap_err()
            .to_string()
            .contains("Expected unsigned XDR but received signed XDR"));

        // Test case 5: Operations with fee_bump should fail
        let stellar_request = StellarTransactionRequest {
            source_account: Some(
                "GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF".to_string(),
            ),
            network: "testnet".to_string(),
            operations: Some(vec![OperationSpec::Payment {
                destination: "GBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB".to_string(),
                amount: 1000000,
                asset: AssetSpec::Native,
            }]),
            memo: None,
            valid_until: None,
            transaction_xdr: None,
            fee_bump: Some(true),
            max_fee: None,
            signed_auth_entry: None,
        };

        let request = NetworkTransactionRequest::Stellar(stellar_request);
        let result = TransactionRepoModel::try_from((&request, &relayer_model, &network_model));
        assert!(result.is_err());
        assert!(result
            .unwrap_err()
            .to_string()
            .contains("Cannot request fee_bump with operations mode"));
    }

    #[test]
    fn test_invoke_host_function_must_be_exclusive() {
        let (network_model, relayer_model) = test_models();

        // Test case 1: Single InvokeHostFunction - should succeed
        let stellar_request = StellarTransactionRequest {
            source_account: Some(
                "GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF".to_string(),
            ),
            network: "testnet".to_string(),
            operations: Some(vec![OperationSpec::InvokeContract {
                contract_address: "CA7QYNF7SOWQ3GLR2BGMZEHXAVIRZA4KVWLTJJFC7MGXUA74P7UJUWDA"
                    .to_string(),
                function_name: "transfer".to_string(),
                args: vec![],
                auth: None,
            }]),
            memo: None,
            valid_until: None,
            transaction_xdr: None,
            fee_bump: None,
            max_fee: None,
            signed_auth_entry: None,
        };

        let request = NetworkTransactionRequest::Stellar(stellar_request);
        let result = TransactionRepoModel::try_from((&request, &relayer_model, &network_model));
        assert!(result.is_ok(), "Single InvokeHostFunction should succeed");

        // Test case 2: InvokeHostFunction mixed with Payment - should fail
        let stellar_request = StellarTransactionRequest {
            source_account: Some(
                "GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF".to_string(),
            ),
            network: "testnet".to_string(),
            operations: Some(vec![
                OperationSpec::Payment {
                    destination: "GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF"
                        .to_string(),
                    amount: 1000,
                    asset: AssetSpec::Native,
                },
                OperationSpec::InvokeContract {
                    contract_address: "CA7QYNF7SOWQ3GLR2BGMZEHXAVIRZA4KVWLTJJFC7MGXUA74P7UJUWDA"
                        .to_string(),
                    function_name: "transfer".to_string(),
                    args: vec![],
                    auth: None,
                },
            ]),
            memo: None,
            valid_until: None,
            transaction_xdr: None,
            fee_bump: None,
            max_fee: None,
            signed_auth_entry: None,
        };

        let request = NetworkTransactionRequest::Stellar(stellar_request);
        let result = TransactionRepoModel::try_from((&request, &relayer_model, &network_model));

        match result {
            Ok(_) => panic!("Expected Soroban operation mixed with Payment to fail"),
            Err(err) => {
                let err_str = err.to_string();
                assert!(
                    err_str.contains("Soroban operations must be exclusive"),
                    "Expected error about Soroban operation exclusivity, got: {err_str}"
                );
            }
        }

        // Test case 3: Multiple InvokeHostFunction operations - should fail
        let stellar_request = StellarTransactionRequest {
            source_account: Some(
                "GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF".to_string(),
            ),
            network: "testnet".to_string(),
            operations: Some(vec![
                OperationSpec::InvokeContract {
                    contract_address: "CA7QYNF7SOWQ3GLR2BGMZEHXAVIRZA4KVWLTJJFC7MGXUA74P7UJUWDA"
                        .to_string(),
                    function_name: "transfer".to_string(),
                    args: vec![],
                    auth: None,
                },
                OperationSpec::InvokeContract {
                    contract_address: "CA7QYNF7SOWQ3GLR2BGMZEHXAVIRZA4KVWLTJJFC7MGXUA74P7UJUWDA"
                        .to_string(),
                    function_name: "approve".to_string(),
                    args: vec![],
                    auth: None,
                },
            ]),
            memo: None,
            valid_until: None,
            transaction_xdr: None,
            fee_bump: None,
            max_fee: None,
            signed_auth_entry: None,
        };

        let request = NetworkTransactionRequest::Stellar(stellar_request);
        let result = TransactionRepoModel::try_from((&request, &relayer_model, &network_model));

        match result {
            Ok(_) => panic!("Expected multiple Soroban operations to fail"),
            Err(err) => {
                let err_str = err.to_string();
                assert!(
                    err_str.contains("Transaction can contain at most one Soroban operation"),
                    "Expected error about multiple Soroban operations, got: {err_str}"
                );
            }
        }

        // Test case 4: Multiple Payment operations - should succeed
        let stellar_request = StellarTransactionRequest {
            source_account: Some(
                "GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF".to_string(),
            ),
            network: "testnet".to_string(),
            operations: Some(vec![
                OperationSpec::Payment {
                    destination: "GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF"
                        .to_string(),
                    amount: 1000,
                    asset: AssetSpec::Native,
                },
                OperationSpec::Payment {
                    destination: "GBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB"
                        .to_string(),
                    amount: 2000,
                    asset: AssetSpec::Native,
                },
            ]),
            memo: None,
            valid_until: None,
            transaction_xdr: None,
            fee_bump: None,
            max_fee: None,
            signed_auth_entry: None,
        };

        let request = NetworkTransactionRequest::Stellar(stellar_request);
        let result = TransactionRepoModel::try_from((&request, &relayer_model, &network_model));
        assert!(result.is_ok(), "Multiple Payment operations should succeed");

        // Test case 5: InvokeHostFunction with non-None memo - should fail
        let stellar_request = StellarTransactionRequest {
            source_account: Some(
                "GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF".to_string(),
            ),
            network: "testnet".to_string(),
            operations: Some(vec![OperationSpec::InvokeContract {
                contract_address: "CA7QYNF7SOWQ3GLR2BGMZEHXAVIRZA4KVWLTJJFC7MGXUA74P7UJUWDA"
                    .to_string(),
                function_name: "transfer".to_string(),
                args: vec![],
                auth: None,
            }]),
            memo: Some(MemoSpec::Text {
                value: "This should fail".to_string(),
            }),
            valid_until: None,
            transaction_xdr: None,
            fee_bump: None,
            max_fee: None,
            signed_auth_entry: None,
        };

        let request = NetworkTransactionRequest::Stellar(stellar_request);
        let result = TransactionRepoModel::try_from((&request, &relayer_model, &network_model));

        match result {
            Ok(_) => panic!("Expected InvokeHostFunction with non-None memo to fail"),
            Err(err) => {
                let err_str = err.to_string();
                assert!(
                    err_str.contains("Soroban operations cannot have a memo"),
                    "Expected error about memo restriction, got: {err_str}"
                );
            }
        }

        // Test case 6: InvokeHostFunction with memo None - should succeed
        let stellar_request = StellarTransactionRequest {
            source_account: Some(
                "GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF".to_string(),
            ),
            network: "testnet".to_string(),
            operations: Some(vec![OperationSpec::InvokeContract {
                contract_address: "CA7QYNF7SOWQ3GLR2BGMZEHXAVIRZA4KVWLTJJFC7MGXUA74P7UJUWDA"
                    .to_string(),
                function_name: "transfer".to_string(),
                args: vec![],
                auth: None,
            }]),
            memo: Some(MemoSpec::None),
            valid_until: None,
            transaction_xdr: None,
            fee_bump: None,
            max_fee: None,
            signed_auth_entry: None,
        };

        let request = NetworkTransactionRequest::Stellar(stellar_request);
        let result = TransactionRepoModel::try_from((&request, &relayer_model, &network_model));
        assert!(
            result.is_ok(),
            "InvokeHostFunction with MemoSpec::None should succeed"
        );

        // Test case 7: InvokeHostFunction with no memo field - should succeed
        let stellar_request = StellarTransactionRequest {
            source_account: Some(
                "GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF".to_string(),
            ),
            network: "testnet".to_string(),
            operations: Some(vec![OperationSpec::InvokeContract {
                contract_address: "CA7QYNF7SOWQ3GLR2BGMZEHXAVIRZA4KVWLTJJFC7MGXUA74P7UJUWDA"
                    .to_string(),
                function_name: "transfer".to_string(),
                args: vec![],
                auth: None,
            }]),
            memo: None,
            valid_until: None,
            transaction_xdr: None,
            fee_bump: None,
            max_fee: None,
            signed_auth_entry: None,
        };

        let request = NetworkTransactionRequest::Stellar(stellar_request);
        let result = TransactionRepoModel::try_from((&request, &relayer_model, &network_model));
        assert!(
            result.is_ok(),
            "InvokeHostFunction with no memo should succeed"
        );

        // Test case 8: Payment operation with memo - should succeed
        let stellar_request = StellarTransactionRequest {
            source_account: Some(
                "GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF".to_string(),
            ),
            network: "testnet".to_string(),
            operations: Some(vec![OperationSpec::Payment {
                destination: "GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF".to_string(),
                amount: 1000,
                asset: AssetSpec::Native,
            }]),
            memo: Some(MemoSpec::Text {
                value: "Payment memo is allowed".to_string(),
            }),
            valid_until: None,
            transaction_xdr: None,
            fee_bump: None,
            max_fee: None,
            signed_auth_entry: None,
        };

        let request = NetworkTransactionRequest::Stellar(stellar_request);
        let result = TransactionRepoModel::try_from((&request, &relayer_model, &network_model));
        assert!(result.is_ok(), "Payment operation with memo should succeed");
    }

    #[test]
    fn test_update_delete_at_if_final_status_does_not_update_when_delete_at_already_set() {
        let _lock = match ENV_MUTEX.lock() {
            Ok(guard) => guard,
            Err(poisoned) => poisoned.into_inner(),
        };

        use std::env;

        // Set custom expiration hours for test
        env::set_var("TRANSACTION_EXPIRATION_HOURS", "6");

        let mut transaction = create_test_transaction();
        transaction.delete_at = Some("2024-01-01T00:00:00Z".to_string());
        transaction.status = TransactionStatus::Confirmed; // Final status

        let original_delete_at = transaction.delete_at.clone();

        transaction.update_delete_at_if_final_status();

        // Should not change delete_at when it's already set
        assert_eq!(transaction.delete_at, original_delete_at);

        // Cleanup
        env::remove_var("TRANSACTION_EXPIRATION_HOURS");
    }

    #[test]
    fn test_update_delete_at_if_final_status_does_not_update_when_status_not_final() {
        let _lock = match ENV_MUTEX.lock() {
            Ok(guard) => guard,
            Err(poisoned) => poisoned.into_inner(),
        };

        use std::env;

        // Set custom expiration hours for test
        env::set_var("TRANSACTION_EXPIRATION_HOURS", "6");

        let mut transaction = create_test_transaction();
        transaction.delete_at = None;
        transaction.status = TransactionStatus::Pending; // Non-final status

        transaction.update_delete_at_if_final_status();

        // Should not set delete_at for non-final status
        assert!(transaction.delete_at.is_none());

        // Cleanup
        env::remove_var("TRANSACTION_EXPIRATION_HOURS");
    }

    #[test]
    fn test_update_delete_at_if_final_status_sets_delete_at_for_final_statuses() {
        let _lock = match ENV_MUTEX.lock() {
            Ok(guard) => guard,
            Err(poisoned) => poisoned.into_inner(),
        };

        use crate::config::ServerConfig;
        use chrono::{DateTime, Duration, Utc};
        use std::env;

        // Set custom expiration hours for test
        env::set_var("TRANSACTION_EXPIRATION_HOURS", "3"); // Use 3 hours for this test

        // Verify the env var is actually set correctly
        let actual_hours = ServerConfig::get_transaction_expiration_hours();
        assert_eq!(
            actual_hours, 3.0,
            "Environment variable should be set to 3 hours"
        );

        let final_statuses = vec![
            TransactionStatus::Canceled,
            TransactionStatus::Confirmed,
            TransactionStatus::Failed,
            TransactionStatus::Expired,
        ];

        for status in final_statuses {
            let mut transaction = create_test_transaction();
            transaction.delete_at = None;
            transaction.status = status.clone();

            let before_update = Utc::now();
            transaction.update_delete_at_if_final_status();

            // Should set delete_at for final status
            assert!(
                transaction.delete_at.is_some(),
                "delete_at should be set for status: {status:?}"
            );

            // Verify the timestamp is reasonable
            let delete_at_str = transaction.delete_at.unwrap();
            let delete_at = DateTime::parse_from_rfc3339(&delete_at_str)
                .expect("delete_at should be valid RFC3339")
                .with_timezone(&Utc);

            // Should be approximately 3 hours from before_update
            let duration_from_before = delete_at.signed_duration_since(before_update);
            let expected_duration = Duration::hours(3);
            let tolerance = Duration::minutes(5); // Allow 5 minutes tolerance

            // Debug information
            let actual_hours_at_runtime = ServerConfig::get_transaction_expiration_hours();

            assert!(
                duration_from_before >= expected_duration - tolerance &&
                duration_from_before <= expected_duration + tolerance,
                "delete_at should be approximately 3 hours from now for status: {status:?}. Duration from start: {duration_from_before:?}, Expected: {expected_duration:?}, Config hours at runtime: {actual_hours_at_runtime}"
            );
        }

        // Cleanup
        env::remove_var("TRANSACTION_EXPIRATION_HOURS");
    }

    #[test]
    fn test_update_delete_at_if_final_status_uses_default_expiration_hours() {
        let _lock = match ENV_MUTEX.lock() {
            Ok(guard) => guard,
            Err(poisoned) => poisoned.into_inner(),
        };

        use chrono::{DateTime, Duration, Utc};
        use std::env;

        // Remove env var to test default behavior
        env::remove_var("TRANSACTION_EXPIRATION_HOURS");

        let mut transaction = create_test_transaction();
        transaction.delete_at = None;
        transaction.status = TransactionStatus::Confirmed;

        let before_update = Utc::now();
        transaction.update_delete_at_if_final_status();

        // Should set delete_at using default value (4 hours)
        assert!(transaction.delete_at.is_some());

        let delete_at_str = transaction.delete_at.unwrap();
        let delete_at = DateTime::parse_from_rfc3339(&delete_at_str)
            .expect("delete_at should be valid RFC3339")
            .with_timezone(&Utc);

        // Should be approximately 4 hours from before_update (default value)
        let duration_from_before = delete_at.signed_duration_since(before_update);
        let expected_duration = Duration::hours(4);
        let tolerance = Duration::minutes(5); // Allow 5 minutes tolerance

        assert!(
            duration_from_before >= expected_duration - tolerance &&
            duration_from_before <= expected_duration + tolerance,
            "delete_at should be approximately 4 hours from now (default). Duration from start: {duration_from_before:?}, Expected: {expected_duration:?}"
        );
    }

    #[test]
    fn test_update_delete_at_if_final_status_with_custom_expiration_hours() {
        let _lock = match ENV_MUTEX.lock() {
            Ok(guard) => guard,
            Err(poisoned) => poisoned.into_inner(),
        };

        use chrono::{DateTime, Duration, Utc};
        use std::env;

        // Test with various custom expiration hours
        let test_cases = vec![1, 2, 6, 12]; // 1 hour, 2 hours, 6 hours, 12 hours

        for expiration_hours in test_cases {
            env::set_var("TRANSACTION_EXPIRATION_HOURS", expiration_hours.to_string());

            let mut transaction = create_test_transaction();
            transaction.delete_at = None;
            transaction.status = TransactionStatus::Failed;

            let before_update = Utc::now();
            transaction.update_delete_at_if_final_status();

            assert!(
                transaction.delete_at.is_some(),
                "delete_at should be set for {expiration_hours} hours"
            );

            let delete_at_str = transaction.delete_at.unwrap();
            let delete_at = DateTime::parse_from_rfc3339(&delete_at_str)
                .expect("delete_at should be valid RFC3339")
                .with_timezone(&Utc);

            let duration_from_before = delete_at.signed_duration_since(before_update);
            let expected_duration = Duration::hours(expiration_hours as i64);
            let tolerance = Duration::minutes(5); // Allow 5 minutes tolerance

            assert!(
                duration_from_before >= expected_duration - tolerance &&
                duration_from_before <= expected_duration + tolerance,
                "delete_at should be approximately {expiration_hours} hours from now. Duration from start: {duration_from_before:?}, Expected: {expected_duration:?}"
            );
        }

        // Cleanup
        env::remove_var("TRANSACTION_EXPIRATION_HOURS");
    }

    #[test]
    fn test_calculate_delete_at_with_various_hours() {
        use chrono::{DateTime, Utc};

        let test_cases = vec![0, 1, 6, 12, 24, 48];

        for hours in test_cases {
            let before_calc = Utc::now();
            let result = TransactionRepoModel::calculate_delete_at(hours as f64);
            let after_calc = Utc::now();

            assert!(
                result.is_some(),
                "calculate_delete_at should return Some for {hours} hours"
            );

            let delete_at_str = result.unwrap();
            let delete_at = DateTime::parse_from_rfc3339(&delete_at_str)
                .expect("Result should be valid RFC3339")
                .with_timezone(&Utc);

            let expected_min =
                before_calc + chrono::Duration::hours(hours as i64) - chrono::Duration::seconds(1);
            let expected_max =
                after_calc + chrono::Duration::hours(hours as i64) + chrono::Duration::seconds(1);

            assert!(
                delete_at >= expected_min && delete_at <= expected_max,
                "Calculated delete_at should be approximately {hours} hours from now. Got: {delete_at}, Expected between: {expected_min} and {expected_max}"
            );
        }
    }

    #[test]
    fn test_update_delete_at_if_final_status_idempotent() {
        let _lock = match ENV_MUTEX.lock() {
            Ok(guard) => guard,
            Err(poisoned) => poisoned.into_inner(),
        };

        use std::env;

        env::set_var("TRANSACTION_EXPIRATION_HOURS", "8");

        let mut transaction = create_test_transaction();
        transaction.delete_at = None;
        transaction.status = TransactionStatus::Confirmed;

        // First call should set delete_at
        transaction.update_delete_at_if_final_status();
        let first_delete_at = transaction.delete_at.clone();
        assert!(first_delete_at.is_some());

        // Second call should not change delete_at (idempotent)
        transaction.update_delete_at_if_final_status();
        assert_eq!(transaction.delete_at, first_delete_at);

        // Third call should not change delete_at (idempotent)
        transaction.update_delete_at_if_final_status();
        assert_eq!(transaction.delete_at, first_delete_at);

        // Cleanup
        env::remove_var("TRANSACTION_EXPIRATION_HOURS");
    }

    /// Helper function to create a test transaction for testing delete_at functionality
    fn create_test_transaction() -> TransactionRepoModel {
        TransactionRepoModel {
            id: "test-transaction-id".to_string(),
            relayer_id: "test-relayer-id".to_string(),
            status: TransactionStatus::Pending,
            status_reason: None,
            created_at: "2024-01-01T00:00:00Z".to_string(),
            sent_at: None,
            confirmed_at: None,
            valid_until: None,
            delete_at: None,
            network_data: NetworkTransactionData::Evm(EvmTransactionData {
                gas_price: None,
                gas_limit: Some(21000),
                nonce: Some(0),
                value: U256::from(0),
                data: None,
                from: "0x1234567890123456789012345678901234567890".to_string(),
                to: Some("0x0987654321098765432109876543210987654321".to_string()),
                chain_id: 1,
                hash: None,
                signature: None,
                speed: None,
                max_fee_per_gas: None,
                max_priority_fee_per_gas: None,
                raw: None,
            }),
            priced_at: None,
            hashes: vec![],
            network_type: NetworkType::Evm,
            noop_count: None,
            is_canceled: None,
            metadata: None,
        }
    }

    #[test]
    fn test_apply_partial_update() {
        // Create a test transaction
        let mut transaction = create_test_transaction();

        // Create a partial update request
        let update = TransactionUpdateRequest {
            status: Some(TransactionStatus::Confirmed),
            status_reason: Some("Transaction confirmed".to_string()),
            sent_at: Some("2023-01-01T12:00:00Z".to_string()),
            confirmed_at: Some("2023-01-01T12:05:00Z".to_string()),
            hashes: Some(vec!["0x123".to_string(), "0x456".to_string()]),
            is_canceled: Some(false),
            ..Default::default()
        };

        // Apply the partial update
        transaction.apply_partial_update(update);

        // Verify the updates were applied
        assert_eq!(transaction.status, TransactionStatus::Confirmed);
        assert_eq!(
            transaction.status_reason,
            Some("Transaction confirmed".to_string())
        );
        assert_eq!(
            transaction.sent_at,
            Some("2023-01-01T12:00:00Z".to_string())
        );
        assert_eq!(
            transaction.confirmed_at,
            Some("2023-01-01T12:05:00Z".to_string())
        );
        assert_eq!(
            transaction.hashes,
            vec!["0x123".to_string(), "0x456".to_string()]
        );
        assert_eq!(transaction.is_canceled, Some(false));

        // Verify that delete_at was set because status changed to final
        assert!(transaction.delete_at.is_some());
    }

    #[test]
    fn test_apply_partial_update_preserves_unchanged_fields() {
        // Create a test transaction with initial values
        let mut transaction = TransactionRepoModel {
            id: "test-tx".to_string(),
            relayer_id: "test-relayer".to_string(),
            status: TransactionStatus::Pending,
            status_reason: Some("Initial reason".to_string()),
            created_at: Utc::now().to_rfc3339(),
            sent_at: Some("2023-01-01T10:00:00Z".to_string()),
            confirmed_at: None,
            valid_until: None,
            delete_at: None,
            network_data: NetworkTransactionData::Evm(EvmTransactionData::default()),
            priced_at: None,
            hashes: vec!["0xoriginal".to_string()],
            network_type: NetworkType::Evm,
            noop_count: Some(5),
            is_canceled: Some(true),
            metadata: None,
        };

        // Create a partial update that only changes status
        let update = TransactionUpdateRequest {
            status: Some(TransactionStatus::Sent),
            ..Default::default()
        };

        // Apply the partial update
        transaction.apply_partial_update(update);

        // Verify only status changed, other fields preserved
        assert_eq!(transaction.status, TransactionStatus::Sent);
        assert_eq!(
            transaction.status_reason,
            Some("Initial reason".to_string())
        );
        assert_eq!(
            transaction.sent_at,
            Some("2023-01-01T10:00:00Z".to_string())
        );
        assert_eq!(transaction.confirmed_at, None);
        assert_eq!(transaction.hashes, vec!["0xoriginal".to_string()]);
        assert_eq!(transaction.noop_count, Some(5));
        assert_eq!(transaction.is_canceled, Some(true));

        // Status is not final, so delete_at should remain None
        assert!(transaction.delete_at.is_none());
    }

    #[test]
    fn test_apply_partial_update_empty_update() {
        // Create a test transaction
        let mut transaction = create_test_transaction();
        let original_transaction = transaction.clone();

        // Apply an empty update
        let update = TransactionUpdateRequest::default();
        transaction.apply_partial_update(update);

        // Verify nothing changed
        assert_eq!(transaction.id, original_transaction.id);
        assert_eq!(transaction.status, original_transaction.status);
        assert_eq!(
            transaction.status_reason,
            original_transaction.status_reason
        );
        assert_eq!(transaction.sent_at, original_transaction.sent_at);
        assert_eq!(transaction.confirmed_at, original_transaction.confirmed_at);
        assert_eq!(transaction.hashes, original_transaction.hashes);
        assert_eq!(transaction.noop_count, original_transaction.noop_count);
        assert_eq!(transaction.is_canceled, original_transaction.is_canceled);
        assert_eq!(transaction.delete_at, original_transaction.delete_at);
    }

    mod extract_stellar_valid_until_tests {
        use super::*;
        use crate::models::transaction::request::stellar::StellarTransactionRequest;
        use chrono::{Duration, Utc};

        fn make_stellar_request(
            valid_until: Option<String>,
            transaction_xdr: Option<String>,
        ) -> StellarTransactionRequest {
            StellarTransactionRequest {
                source_account: Some(
                    "GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF".to_string(),
                ),
                network: "testnet".to_string(),
                operations: Some(vec![OperationSpec::Payment {
                    destination: "GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF"
                        .to_string(),
                    amount: 1000000,
                    asset: AssetSpec::Native,
                }]),
                memo: None,
                valid_until,
                transaction_xdr,
                fee_bump: None,
                max_fee: None,
                signed_auth_entry: None,
            }
        }

        #[test]
        fn test_with_explicit_valid_until_from_request() {
            let request = make_stellar_request(Some("2025-12-31T23:59:59Z".to_string()), None);
            let now = Utc::now();

            let result = extract_stellar_valid_until(&request, now);

            assert_eq!(result, Some("2025-12-31T23:59:59Z".to_string()));
        }

        #[test]
        fn test_operations_without_valid_until_uses_default() {
            let request = make_stellar_request(None, None);
            let now = Utc::now();

            let result = extract_stellar_valid_until(&request, now);

            // Should be now + STELLAR_SPONSORED_TRANSACTION_VALIDITY_MINUTES (2 min)
            assert!(result.is_some());
            let valid_until = result.unwrap();
            let parsed = chrono::DateTime::parse_from_rfc3339(&valid_until).unwrap();
            let expected_min = now + Duration::minutes(1);
            let expected_max = now + Duration::minutes(3);
            assert!(parsed.with_timezone(&Utc) > expected_min);
            assert!(parsed.with_timezone(&Utc) < expected_max);
        }

        #[test]
        fn test_xdr_without_time_bounds_returns_none() {
            // Create a minimal unsigned XDR without time bounds
            // This is a base64 encoded transaction envelope without time bounds
            // For simplicity, we'll test with invalid XDR which should also return None
            let request = make_stellar_request(None, Some("invalid_xdr".to_string()));
            let now = Utc::now();

            let result = extract_stellar_valid_until(&request, now);

            // XDR parse failed or no time_bounds - should return None (unbounded)
            assert!(result.is_none());
        }
    }
}